Attachment 236304 Details for Bug 419027 – patch for project nav

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

patch for project nav

file_419027.txt (text/plain), 1.72 KB, created by Silenio Quarti

on 2013-10-09 17:16:11 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Silenio Quarti

Created: 2013-10-09 17:16:11 EDT

Size: 1.72 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/widgets/nav/project-nav.js b/bundles/org.eclipse.orion.client.ui/web/orion/widgets/nav/project-nav.js
>index 5ccd291..6be4117 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/widgets/nav/project-nav.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/widgets/nav/project-nav.js
>@@ -92,6 +92,7 @@
> 	function FilesNavExplorer(params, projectExplorer) {
> 		params.setFocus = false;   // do not steal focus on load
> 		params.cachePrefix = null; // do not persist table state
>+		params.modelEventDispatcher = FileCommands.getModelEventDispatcher();
> 		FileExplorer.apply(this, arguments);
> 		this.commandRegistry = params.commandRegistry;
> 		this.projectClient = params.projectClient;
>@@ -113,7 +114,7 @@
> 
> 		// Listen to model changes from fileCommands
> 		var dispatcher = this.modelEventDispatcher;
>-		var onChange = this.onFileModelChange.bind(this);
>+		var onChange = this._modelListener = this.onFileModelChange.bind(this);
> 		["move", "delete"].forEach(function(type) { //$NON-NLS-1$ //$NON-NLS-0$
> 			dispatcher.addEventListener(type, onChange);
> 		});
>@@ -164,6 +165,12 @@
> 			}
> 		},
> 		destroy: function() {
>+			var _self = this;
>+			var dispatcher = this.modelEventDispatcher;
>+			["move", "delete"].forEach(function(type) { //$NON-NLS-1$ //$NON-NLS-0$
>+				dispatcher.removeEventListener(type, _self._modelListener);
>+			});
>+			FileExplorer.prototype.destroy.call(this);
> 		},
> 		/**
> 		 * Loads the given children location as the root.
>@@ -605,6 +612,10 @@
> 
> 		},
> 		destroy : function(){
>+			if (this.fileExplorer) {
>+				this.fileExplorer.destroy();
>+				this.fileExplorer = null;
>+			}
> 		},
> 		constructor: ProjectNavExplorer
> 	};

Actions: View

Attachments on bug 419027: 236288 | 236304