Attachment 236144 Details for Bug 418746 – (Patch for commit 43b0dc87e902de5a9bfbb0b494e57132fd990253). This is not the best solution (as the TODOs in this file are pointing out - there is a need to create a thread safe thread list)

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] (Patch for commit 43b0dc87e902de5a9bfbb0b494e57132fd990253). This is not the best solution (as the TODOs in this file are pointing out - there is a need to create a thread safe thread list)

jdt.threadstarthanderfix.patch (text/plain), 1.57 KB, created by Stepan Vavra

on 2013-10-05 13:54:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stepan Vavra

Created: 2013-10-05 13:54:26 EDT

Size: 1.57 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.debug
>diff --git model/org/eclipse/jdt/internal/debug/core/model/JDIDebugTarget.java model/org/eclipse/jdt/internal/debug/core/model/JDIDebugTarget.java
>index e71be4c..74339a2 100644
>--- model/org/eclipse/jdt/internal/debug/core/model/JDIDebugTarget.java
>+++ model/org/eclipse/jdt/internal/debug/core/model/JDIDebugTarget.java
>@@ -1955,31 +1957,33 @@
> 				if (thread.isCollected()) {
> 					return false;
> 				}
> 			} catch (VMDisconnectedException exception) {
> 				return false;
> 			} catch (ObjectCollectedException e) {
> 				return false;
> 			} catch (TimeoutException e) {
> 				// continue - attempt to create the thread
> 			}
>-			JDIThread jdiThread = findThread(thread);
>-			if (jdiThread == null) {
>-				jdiThread = createThread(thread);
>+			synchronized (fThreads) {
>+				JDIThread jdiThread = findThread(thread);
> 				if (jdiThread == null) {
>-					return false;
>+					jdiThread = createThread(thread);
>+					if (jdiThread == null) {
>+						return false;
>+					}
>+				} else {
>+					jdiThread.disposeStackFrames();
>+					jdiThread.fireChangeEvent(DebugEvent.CONTENT);
> 				}
>-			} else {
>-				jdiThread.disposeStackFrames();
>-				jdiThread.fireChangeEvent(DebugEvent.CONTENT);
>+				return !jdiThread.isSuspended();
> 			}
>-			return !jdiThread.isSuspended();
> 		}
> 
> 		/*
> 		 * (non-Javadoc)
> 		 * 
> 		 * @see
> 		 * org.eclipse.jdt.internal.debug.core.IJDIEventListener#eventSetComplete
> 		 * (com.sun.jdi.event.Event,
> 		 * org.eclipse.jdt.internal.debug.core.model.JDIDebugTarget, boolean)
> 		 */
>

Actions: View | Diff

Attachments on bug 418746: 236144