Attachment 235976 Details for Bug 418298 – a simpler solution

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] a simpler solution

0001-F3-now-opens-editor-for-specTCs-testSuites-and-testJ.patch (text/plain), 6.65 KB, created by Sebastian Struckmann

on 2013-09-30 11:09:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sebastian Struckmann

Created: 2013-09-30 11:09:00 EDT

Size: 6.65 KB

patch

obsolete

>From 8a6c31229df40ef9eabbd0516a584647d16ed0c8 Mon Sep 17 00:00:00 2001
>From: Sebastian Struckmann <sebastian.struckmann@bredex.de>
>Date: Mon, 30 Sep 2013 17:03:59 +0200
>Subject: [PATCH] F3 now opens editor for specTCs, testSuites and testJobs
>
>---
> org.eclipse.jubula.client.ui.rcp/plugin.xml | 132 ++++++++++++++++++----------
> 1 file changed, 87 insertions(+), 45 deletions(-)
>
>diff --git a/org.eclipse.jubula.client.ui.rcp/plugin.xml b/org.eclipse.jubula.client.ui.rcp/plugin.xml
>index 4731b1f..1c20ce2 100644
>--- a/org.eclipse.jubula.client.ui.rcp/plugin.xml
>+++ b/org.eclipse.jubula.client.ui.rcp/plugin.xml
>@@ -75,6 +75,57 @@
>         </with>
>      </or>
>     </definition>
>+    <definition id="org.eclipse.jubula.client.ui.rcp.expression.openTestCaseEditorFromTestCaseBrowser">
>+      <and>
>+          <with variable="activePartId">
>+            <equals value="org.eclipse.jubula.client.ui.rcp.views.TestCaseBrowser" />
>+          </with>
>+          <iterate
>+            ifEmpty="false"
>+            operator="and">
>+            <and>
>+              <not>
>+                <or>
>+                  <instanceof value="org.eclipse.jubula.client.core.model.ICategoryPO" />
>+                </or>
>+              </not>
>+              <test
>+                property="org.eclipse.jubula.client.core.model.isEditable"
>+                value="true" />
>+            </and>
>+          </iterate>
>+        </and>
>+    </definition>
>+    <definition id="org.eclipse.jubula.client.ui.rcp.expression.openTestSuiteEditorFromTestSuiteBrowser">
>+      <and>
>+          <with variable="activePartId">
>+            <equals value="org.eclipse.jubula.client.ui.rcp.views.TestSuiteBrowser" />
>+          </with>
>+          <iterate
>+            ifEmpty="false"
>+            operator="and">
>+            <or>
>+              <instanceof value="org.eclipse.jubula.client.core.model.ITestSuitePO" />
>+              <instanceof value="org.eclipse.jubula.client.core.model.IExecTestCasePO" />
>+            </or>
>+          </iterate>
>+        </and>
>+    </definition>
>+    <definition id="org.eclipse.jubula.client.ui.rcp.expression.openTestJobEditorFromTestSuiteBrowser">
>+      <and>
>+          <with variable="activePartId">
>+            <equals value="org.eclipse.jubula.client.ui.rcp.views.TestSuiteBrowser" />
>+          </with>
>+          <iterate
>+            ifEmpty="false"
>+            operator="and">
>+            <or>
>+              <instanceof value="org.eclipse.jubula.client.core.model.ITestJobPO" />
>+              <instanceof value="org.eclipse.jubula.client.core.model.IRefTestSuitePO" />
>+            </or>
>+          </iterate>
>+        </and>
>+    </definition>
>   </extension>
>   <extension point="org.eclipse.core.expressions.propertyTesters">
>     <propertyTester
>@@ -3399,38 +3450,36 @@
>       class="org.eclipse.jubula.client.ui.rcp.handlers.open.OpenTestSuiteEditorHandler"
>       commandId="org.eclipse.jubula.client.ui.rcp.commands.OpenTestsuiteEditor">
>       <activeWhen>
>-        <and>
>-          <with variable="activePartId">
>-            <equals value="org.eclipse.jubula.client.ui.rcp.views.TestSuiteBrowser" />
>-          </with>
>-          <iterate
>-            ifEmpty="false"
>-            operator="and">
>-            <or>
>-              <instanceof value="org.eclipse.jubula.client.core.model.ITestSuitePO" />
>-              <instanceof value="org.eclipse.jubula.client.core.model.IExecTestCasePO" />
>-            </or>
>-          </iterate>
>-        </and>
>+        <reference
>+              definitionId="org.eclipse.jubula.client.ui.rcp.expression.openTestSuiteEditorFromTestSuiteBrowser">
>+        </reference>
>+      </activeWhen>
>+    </handler>
>+    <handler
>+      class="org.eclipse.jubula.client.ui.rcp.handlers.open.OpenTestSuiteEditorHandler"
>+      commandId="org.eclipse.jubula.client.ui.commands.OpenSpecification">
>+      <activeWhen>
>+        <reference
>+              definitionId="org.eclipse.jubula.client.ui.rcp.expression.openTestSuiteEditorFromTestSuiteBrowser">
>+        </reference>
>       </activeWhen>
>     </handler>
>     <handler
>       class="org.eclipse.jubula.client.ui.rcp.handlers.open.OpenTestJobEditorHandler"
>       commandId="org.eclipse.jubula.client.ui.rcp.commands.OpenTestJobEditor">
>       <activeWhen>
>-        <and>
>-          <with variable="activePartId">
>-            <equals value="org.eclipse.jubula.client.ui.rcp.views.TestSuiteBrowser" />
>-          </with>
>-          <iterate
>-            ifEmpty="false"
>-            operator="and">
>-            <or>
>-              <instanceof value="org.eclipse.jubula.client.core.model.ITestJobPO" />
>-              <instanceof value="org.eclipse.jubula.client.core.model.IRefTestSuitePO" />
>-            </or>
>-          </iterate>
>-        </and>
>+        <reference
>+              definitionId="org.eclipse.jubula.client.ui.rcp.expression.openTestJobEditorFromTestSuiteBrowser">
>+        </reference>
>+      </activeWhen>
>+    </handler>
>+    <handler
>+      class="org.eclipse.jubula.client.ui.rcp.handlers.open.OpenTestJobEditorHandler"
>+      commandId="org.eclipse.jubula.client.ui.commands.OpenSpecification">
>+      <activeWhen>
>+        <reference
>+              definitionId="org.eclipse.jubula.client.ui.rcp.expression.openTestJobEditorFromTestSuiteBrowser">
>+        </reference>
>       </activeWhen>
>     </handler>
>     <handler
>@@ -3461,25 +3510,18 @@
>       class="org.eclipse.jubula.client.ui.rcp.handlers.open.OpenTestCaseEditorHandler"
>       commandId="org.eclipse.jubula.client.ui.rcp.commands.OpenTestcaseEditor">
>       <activeWhen>
>-        <and>
>-          <with variable="activePartId">
>-            <equals value="org.eclipse.jubula.client.ui.rcp.views.TestCaseBrowser" />
>-          </with>
>-          <iterate
>-            ifEmpty="false"
>-            operator="and">
>-            <and>
>-              <not>
>-                <or>
>-                  <instanceof value="org.eclipse.jubula.client.core.model.ICategoryPO" />
>-                </or>
>-              </not>
>-              <test
>-                property="org.eclipse.jubula.client.core.model.isEditable"
>-                value="true" />
>-            </and>
>-          </iterate>
>-        </and>
>+        <reference
>+              definitionId="org.eclipse.jubula.client.ui.rcp.expression.openTestCaseEditorFromTestCaseBrowser">
>+        </reference>
>+      </activeWhen>
>+    </handler>
>+    <handler
>+      class="org.eclipse.jubula.client.ui.rcp.handlers.open.OpenTestCaseEditorHandler"
>+      commandId="org.eclipse.jubula.client.ui.commands.OpenSpecification">
>+      <activeWhen>
>+        <reference
>+              definitionId="org.eclipse.jubula.client.ui.rcp.expression.openTestCaseEditorFromTestCaseBrowser">
>+        </reference>
>       </activeWhen>
>     </handler>
>     <handler
>-- 
>1.7.11
>

Flags:

marvin_m: iplog+

Actions: View | Diff

Attachments on bug 418298: 235946 | 235976 | 237166