Attachment 235847 Details for Bug 417989 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

bug-417989.patch (text/plain), 1.62 KB, created by Ivan Furnadjiev

on 2013-09-26 08:20:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2013-09-26 08:20:36 EDT

Size: 1.62 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.rap.jface/src/org/eclipse/jface/action/CoolBarManager.java b/bundles/org.eclipse.rap.jface/src/org/eclipse/jface/action/CoolBarManager.java
>old mode 100755
>new mode 100644
>index 1f8e297..8e8a3fb
>--- a/bundles/org.eclipse.rap.jface/src/org/eclipse/jface/action/CoolBarManager.java
>+++ b/bundles/org.eclipse.rap.jface/src/org/eclipse/jface/action/CoolBarManager.java
>@@ -66,6 +66,8 @@
>      */
>     private int itemStyle = SWT.NONE;
> 
>+    private boolean inUpdate = false;
>+
>     /**
>      * Creates a new cool bar manager with the default style. Equivalent to
>      * <code>CoolBarManager(SWT.NONE)</code>.
>@@ -261,10 +263,12 @@
>     private void addCoolBarResizeListener() {
>       coolBar.addControlListener( new ControlAdapter() {
>         public void controlResized( ControlEvent event ) {
>-          IContributionItem[] items = getItems();
>-          for( int i = 0; i < items.length; i++ ) {
>-            IContributionItem item = items[ i ];
>-            item.update( SIZE );
>+          if( !inUpdate ) {
>+            IContributionItem[] items = getItems();
>+            for( int i = 0; i < items.length; i++ ) {
>+              IContributionItem item = items[ i ];
>+              item.update( SIZE );
>+            }
>           }
>         }
>       } );
>@@ -850,6 +854,7 @@
> 
>         try {
>             coolBar.setRedraw(false);
>+            inUpdate = true;
> 
>             // Refresh the widget data with the internal data structure.
>             refresh();
>@@ -993,6 +998,7 @@
>             setDirty(false);
>         } finally {
>             coolBar.setRedraw(true);
>+            inUpdate = false;
>         }
>     }
>

Actions: View | Diff

Attachments on bug 417989: 235799 | 235800 | 235847