Attachment 235356 Details for Bug 413483 – Patch to initialize GDBMemory during launch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to initialize GDBMemory during launch

bug413483_patch1.patch (text/plain), 3.91 KB, created by William Riley

on 2013-09-10 10:41:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: William Riley

Created: 2013-09-10 10:41:05 EDT

Size: 3.91 KB

patch

obsolete

>diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/StartOrRestartProcessSequence_7_0.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/StartOrRestartProcessSequence_7_0.java
>index e88e9b6..b4c6181 100644
>--- a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/StartOrRestartProcessSequence_7_0.java
>+++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/StartOrRestartProcessSequence_7_0.java
>@@ -26,6 +26,7 @@
> import org.eclipse.cdt.dsf.concurrent.RequestMonitor;
> import org.eclipse.cdt.dsf.datamodel.DMContexts;
> import org.eclipse.cdt.dsf.debug.service.IBreakpoints.IBreakpointsTargetDMContext;
>+import org.eclipse.cdt.dsf.debug.service.IMemory.IMemoryDMContext;
> import org.eclipse.cdt.dsf.debug.service.IRunControl.IContainerDMContext;
> import org.eclipse.cdt.dsf.debug.service.command.ICommand;
> import org.eclipse.cdt.dsf.gdb.IGDBLaunchConfigurationConstants;
>@@ -134,6 +135,7 @@
> 					"stepInitializeInputOutput",   //$NON-NLS-1$
> 					"stepCreateConsole",    //$NON-NLS-1$
> 					"stepRunProgram",   //$NON-NLS-1$
>+					"stepInitializeMemory",   //$NON-NLS-1$
> 					"stepSetReverseOff",   //$NON-NLS-1$
> 					"stepEnableReverse",   //$NON-NLS-1$
> 					"stepContinue",   //$NON-NLS-1$
>@@ -408,6 +410,21 @@
> 	}
> 	
> 	/**
>+	 * Initialize the memory service with the data for given process.
>+	 * @since 4.2
>+	 */
>+	@Execute
>+	public void stepInitializeMemory(final RequestMonitor rm) {
>+		IGDBMemory memory = fTracker.getService(IGDBMemory.class);
>+		IMemoryDMContext memContext = DMContexts.getAncestorOfType(getContainerContext(), IMemoryDMContext.class);
>+		if (memory == null || memContext == null) {
>+			rm.done();
>+			return;
>+		}
>+		memory.initializeMemoryData(memContext, rm);
>+	}
>+	
>+	/**
> 	 * In case of a restart, we must mark reverse debugging as disabled because
> 	 * GDB has turned it off. We may have to turn it back on after.
> 	 */
>diff --git a/jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java b/jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java
>index 3e2b4a0..7a2c62e 100644
>--- a/jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java
>+++ b/jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java
>@@ -45,9 +45,11 @@
> import org.eclipse.cdt.dsf.concurrent.RequestMonitorWithProgress;
> import org.eclipse.cdt.dsf.datamodel.DMContexts;
> import org.eclipse.cdt.dsf.debug.service.IBreakpoints.IBreakpointsTargetDMContext;
>+import org.eclipse.cdt.dsf.debug.service.IMemory.IMemoryDMContext;
> import org.eclipse.cdt.dsf.gdb.launching.FinalLaunchSequence;
> import org.eclipse.cdt.dsf.gdb.launching.GdbLaunch;
> import org.eclipse.cdt.dsf.gdb.service.IGDBBackend;
>+import org.eclipse.cdt.dsf.gdb.service.IGDBMemory;
> import org.eclipse.cdt.dsf.gdb.service.SessionType;
> import org.eclipse.cdt.dsf.gdb.service.command.IGDBControl;
> import org.eclipse.cdt.dsf.mi.service.IMIContainerDMContext;
>@@ -171,6 +173,8 @@
> 					"stepLoadImage",   //$NON-NLS-1$
> 					
> 					"stepUpdateContainer",   //$NON-NLS-1$
>+					
>+					"stepInitializeMemory",   //$NON-NLS-1$
> 					
> 					"stepSetArguments",   //$NON-NLS-1$
> 					"stepSetEnvironmentVariables",   //$NON-NLS-1$
>@@ -472,6 +476,21 @@
> 	}
> 	
> 	/**
>+	 * Initialize the memory service with the data for given process.
>+	 * @since 4.2
>+	 */
>+	@Execute
>+	public void stepInitializeMemory(final RequestMonitor rm) {
>+		IGDBMemory memory = fTracker.getService(IGDBMemory.class);
>+		IMemoryDMContext memContext = DMContexts.getAncestorOfType(getContainerContext(), IMemoryDMContext.class);
>+		if (memory == null || memContext == null) {
>+			rm.done();
>+			return;
>+		}
>+		memory.initializeMemoryData(memContext, rm);
>+	}
>+	
>+	/**
> 	 * Specify the arguments to the program that will be run.
> 	 * @since 8.2
> 	 */

Flags:

nobody: iplog+

Actions: View | Diff

Attachments on bug 413483: 235356