Attachment 235124 Details for Bug 415860 – Patch accommodating review comments.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch accommodating review comments.

Bug-415860--review-comments.patch (text/plain), 4.14 KB, created by ANIRBAN CHAKRABORTY

on 2013-09-03 18:03:53 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: ANIRBAN CHAKRABORTY

Created: 2013-09-03 18:03:53 EDT

Size: 4.14 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.compiler.apt.tests/resources/targets/dispatch/X.java b/org.eclipse.jdt.compiler.apt.tests/resources/targets/dispatch/X.java
>index 6ad4551..0eada16 100644
>--- a/org.eclipse.jdt.compiler.apt.tests/resources/targets/dispatch/X.java
>+++ b/org.eclipse.jdt.compiler.apt.tests/resources/targets/dispatch/X.java
>@@ -1,12 +1,18 @@
> /*******************************************************************************
>- * Copyright (c) 2007-2009 BEA Systems, Inc. and others
>+ * Copyright (c) 2007-2013 BEA Systems, Inc. and others
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>  * http://www.eclipse.org/legal/epl-v10.html
>  * 
>+ * This is an implementation of an early-draft specification developed under the Java
>+ * Community Process (JCP) and is made available for testing and evaluation purposes
>+ * only. The code is not compatible with any specification of the JCP.
>+ * 
>  * Contributors:
>  *     wharley@bea.com - initial API and implementation
>+ *     IBM Contribution :
>+ *     		Bug 415860 - [1.8][compiler] EclipseCompiler should not hard code compliance level
>  *******************************************************************************/
> import p.Y;
> import p.Z;
>@@ -16,4 +22,9 @@
> 		System.out.println(new Y());
> 		System.out.println(new Z());
> 	}
>+}
>+interface I {
>+	default String defaultMethod () {
>+		return null;
>+	}
> }
>\ No newline at end of file
>diff --git a/org.eclipse.jdt.compiler.tool/src/org/eclipse/jdt/internal/compiler/tool/EclipseCompiler.java b/org.eclipse.jdt.compiler.tool/src/org/eclipse/jdt/internal/compiler/tool/EclipseCompiler.java
>index 52ace6f..01063d8 100644
>--- a/org.eclipse.jdt.compiler.tool/src/org/eclipse/jdt/internal/compiler/tool/EclipseCompiler.java
>+++ b/org.eclipse.jdt.compiler.tool/src/org/eclipse/jdt/internal/compiler/tool/EclipseCompiler.java
>@@ -1,10 +1,14 @@
> /*******************************************************************************
>- * Copyright (c) 2006, 2010 IBM Corporation and others.
>+ * Copyright (c) 2006, 2013 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>  * http://www.eclipse.org/legal/epl-v10.html
>  *
>+ * This is an implementation of an early-draft specification developed under the Java
>+ * Community Process (JCP) and is made available for testing and evaluation purposes
>+ * only. The code is not compatible with any specification of the JCP.
>+ * 
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>  *******************************************************************************/
>@@ -46,9 +50,9 @@
> 	private static Set<SourceVersion> SupportedSourceVersions;
> 	static {
> 		// Eclipse compiler supports all possible versions from version 0 to
>-		// version 6
>+		// latest supported version
> 		// we don't care about the order
>-		EnumSet<SourceVersion> enumSet = EnumSet.range(SourceVersion.RELEASE_0, SourceVersion.RELEASE_6);
>+		EnumSet<SourceVersion> enumSet = EnumSet.range(SourceVersion.RELEASE_0, SourceVersion.latestSupported());
> 		// we don't want anybody to modify this list
> 		EclipseCompiler.SupportedSourceVersions = Collections.unmodifiableSet(enumSet);
> 	}
>@@ -115,9 +119,9 @@
> 			eclipseCompiler2.fileManager = this.getStandardFileManager(someDiagnosticListener, null, null);
> 		}
> 
>-		eclipseCompiler2.options.put(CompilerOptions.OPTION_Compliance, CompilerOptions.VERSION_1_6);
>-		eclipseCompiler2.options.put(CompilerOptions.OPTION_Source, CompilerOptions.VERSION_1_6);
>-		eclipseCompiler2.options.put(CompilerOptions.OPTION_TargetPlatform, CompilerOptions.VERSION_1_6);
>+		eclipseCompiler2.options.put(CompilerOptions.OPTION_Compliance, CompilerOptions.VERSION_1_8);
>+		eclipseCompiler2.options.put(CompilerOptions.OPTION_Source, CompilerOptions.VERSION_1_8);
>+		eclipseCompiler2.options.put(CompilerOptions.OPTION_TargetPlatform, CompilerOptions.VERSION_1_8);
> 
> 		ArrayList<String> allOptions = new ArrayList<String>();
> 		if (options != null) {

Actions: View | Diff

Attachments on bug 415860: 235027 | 235055 | 235063 | 235124