Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 232469 Details for
Bug 410930
Splitter can be dragged past the left edge of the page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
Patch file with EOF, works now when you apply it from Orion
bug410930PatchWithEOF.txt (text/plain), 2.47 KB, created by
libing wang
on 2013-06-17 15:44:33 EDT
(
hide
)
Description:
Patch file with EOF, works now when you apply it from Orion
Filename:
MIME Type:
Creator:
libing wang
Created:
2013-06-17 15:44:33 EDT
Size:
2.47 KB
patch
obsolete
>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/webui/splitter.js b/bundles/org.eclipse.orion.client.ui/web/orion/webui/splitter.js >index 030a25b..c25bf32 100644 >--- a/bundles/org.eclipse.orion.client.ui/web/orion/webui/splitter.js >+++ b/bundles/org.eclipse.orion.client.ui/web/orion/webui/splitter.js >@@ -12,6 +12,7 @@ > > define(['require', 'orion/webui/littlelib'], function(require, lib) { > >+ var MIN_SIDE_NODE_WIDTH = 5;//The minimium width/height of the splitted nodes by the splitter > /** > * Constructs a new Splitter with the given options. A splitter manages the layout > * of two panels, a side panel and a main panel. An optional toggle button can open or close the >@@ -246,20 +247,28 @@ > > _mouseMove: function(event) { > if (this._tracking) { >- var parentRect; >+ var parentRect = lib.bounds(this.$node.parentNode); > if (this._vertical) { > this._splitTop = event.clientY; >+ if(this._splitTop < parentRect.top + MIN_SIDE_NODE_WIDTH) {//If the top side of the splitted node is shorter than the min size >+ this._splitTop = parentRect.top + MIN_SIDE_NODE_WIDTH; >+ } else if(this._splitTop > parentRect.top + parentRect.height - MIN_SIDE_NODE_WIDTH) {//If the bottom side of the splitted node is shorter than the min size >+ this._splitTop = parentRect.top + parentRect.height - MIN_SIDE_NODE_WIDTH; >+ } > var top = this._splitTop; > if (this.$node.parentNode.style.position === "relative") { //$NON-NLS-0$ >- parentRect = lib.bounds(this.$node.parentNode); > top = this._splitTop - parentRect.top; > } > this.$node.style.top = top + "px"; //$NON-NLS-0$ > } else { >- this._splitLeft = event.clientX; >+ this._splitLeft = event.clientX; >+ if(this._splitLeft < parentRect.left + MIN_SIDE_NODE_WIDTH) {//If the left side of the splitted node is narrower than the min size >+ this._splitLeft = parentRect.left + MIN_SIDE_NODE_WIDTH; >+ } else if(this._splitLeft > parentRect.left + parentRect.width - MIN_SIDE_NODE_WIDTH) {//If the right side of the splitted node is narrower than the min size >+ this._splitLeft = parentRect.left + parentRect.width - MIN_SIDE_NODE_WIDTH; >+ } > var left = this._splitLeft; > if (this.$node.parentNode.style.position === "relative") { //$NON-NLS-0$ >- parentRect = lib.bounds(this.$node.parentNode); > left = this._splitLeft - parentRect.left; > } > this.$node.style.left = left + "px"; //$NON-NLS-0$
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 410930
:
232460
| 232469