Attachment 232449 Details for Bug 410933 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

fix

file_410933.txt (text/plain), 1.67 KB, created by Silenio Quarti

on 2013-06-17 11:47:32 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Silenio Quarti

Created: 2013-06-17 11:47:32 EDT

Size: 1.67 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/commandRegistry.js b/bundles/org.eclipse.orion.client.ui/web/orion/commandRegistry.js
>index ef1a2b1..40f2c31 100644
>--- a/bundles/org.eclipse.orion.client.ui/web/orion/commandRegistry.js
>+++ b/bundles/org.eclipse.orion.client.ui/web/orion/commandRegistry.js
>@@ -368,19 +368,27 @@
> 					executeBinding(activeBinding);
> 				};
> 			}
>+			var bindings = [];
> 			for (var aBinding in this._activeBindings) {
> 				binding = this._activeBindings[aBinding];
> 				if (binding && binding.keyBinding && binding.command) {
>-					// skip scopes and process at end
>-					if (binding.keyBinding.scopeName) {
>-						if (!scopes[binding.keyBinding.scopeName]) {
>-							scopes[binding.keyBinding.scopeName] = [];
>-						}
>-						scopes[binding.keyBinding.scopeName].push(binding);
>-					} else {
>-						bindingString = UIUtil.getUserKeyString(binding.keyBinding);
>-						keyAssist.createItem(bindingString, binding.command.name, execute(binding));
>+					bindings.push(binding);
>+				}
>+			}
>+			bindings.sort(function (a, b) {
>+				return a.command.name.localeCompare(b.command.name);
>+			});
>+			for (var i=0; i<bindings.length; i++) {
>+				binding = bindings[i];
>+				// skip scopes and process at end
>+				if (binding.keyBinding.scopeName) {
>+					if (!scopes[binding.keyBinding.scopeName]) {
>+						scopes[binding.keyBinding.scopeName] = [];
> 					}
>+					scopes[binding.keyBinding.scopeName].push(binding);
>+				} else {
>+					bindingString = UIUtil.getUserKeyString(binding.keyBinding);
>+					keyAssist.createItem(bindingString, binding.command.name, execute(binding));
> 				}
> 			}
> 			for (var scopedBinding in scopes) {

Actions: View

Attachments on bug 410933: 232449 | 232464