Attachment 231446 Details for Bug 403769 – Fix for Opera 12

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix for Opera 12

Fix-key-events-in-Opera-12.patch (text/plain), 1.96 KB, created by Tim Buschtoens

on 2013-05-24 06:47:31 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2013-05-24 06:47:31 EDT

Size: 1.96 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>diff --git js/rwt/event/EventHandlerUtil.js js/rwt/event/EventHandlerUtil.js
>index 0e1e52f..f49f639 100644
>--- js/rwt/event/EventHandlerUtil.js
>+++ js/rwt/event/EventHandlerUtil.js
>@@ -215,20 +215,6 @@
>       "gecko" : function( event ) {
>         return event.keyCode;
>       },
>-      "opera" : function( event ) {
>-        var result;
>-        if( event.type === "keypress" ) {
>-          if( this._lastKeyCode === event.keyCode ) {
>-            result = event.keyCode;
>-          } else {
>-            // This is a printable "keypress", the keyCode is not relevant:
>-            result = 0;
>-          }
>-        } else {
>-          result = event.keyCode;
>-        }
>-        return result;
>-      },
>       "default" : function( event ) {
>         // the value in "keyCode" on "keypress" is actually the charcode:
>         var hasKeyCode = event.type !== "keypress" || event.keyCode === 13 || event.keyCode === 27;
>@@ -241,23 +227,9 @@
>         var hasCharCode = event.type === "keypress" && event.keyCode !== 13 && event.keyCode !== 27;
>         return hasCharCode ? event.charCode : 0;
>       },
>-      "mshtml|newmshtml" : function( event ) {
>+      "mshtml|newmshtml|opera" : function( event ) {
>         var hasCharCode = event.type === "keypress" && event.keyCode !== 13 && event.keyCode !== 27;
>         return hasCharCode ? event.keyCode : 0;
>-      },
>-      "opera" : function( event ) {
>-        var result;
>-        if( event.type === "keypress" ) {
>-          if( this._lastKeyCode !== event.keyCode ) {
>-            result = event.keyCode;
>-          } else {
>-            // This is a non-printable "keypress"
>-            result = 0;
>-          }
>-        } else {
>-          result = 0;
>-        }
>-        return result;
>       }
>     } ),
> 
>@@ -299,9 +271,6 @@
>           }
>         }
>         return result;
>-      },
>-      "opera" : function( event, keyCode, charCode ) {
>-        return [ event.type ];
>       }
>     } ),
>

Flags:

ivan: review+

Actions: View | Diff

Attachments on bug 403769: 231446