Attachment 231311 Details for Bug 408701 – Fix with test

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix with test

Prevent-application-crash-by-floatpoint-mouse-coordi.patch (text/plain), 3.41 KB, created by Tim Buschtoens

on 2013-05-22 11:01:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2013-05-22 11:01:10 EDT

Size: 3.41 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>diff --git js/rwt/event/MouseEvent.js js/rwt/event/MouseEvent.js
>index 166a589..54bb732 100644
>--- js/rwt/event/MouseEvent.js
>+++ js/rwt/event/MouseEvent.js
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- *  Copyright: 2004, 2012 1&1 Internet AG, Germany, http://www.1und1.de,
>+ *  Copyright: 2004, 2013 1&1 Internet AG, Germany, http://www.1und1.de,
>  *                        and EclipseSource
>  *
>  * This program and the accompanying materials are made available under the
>@@ -224,11 +224,11 @@
>     getPageX : rwt.util.Variant.select("qx.client",
>     {
>       "mshtml" : function() {
>-        return this.getDomEvent().clientX + rwt.html.Viewport.getScrollLeft(window);
>+        return Math.round( this.getDomEvent().clientX + rwt.html.Viewport.getScrollLeft( window ) );
>       },
> 
>       "default" : function() {
>-        return this.getDomEvent().pageX;
>+        return Math.round( this.getDomEvent().pageX );
>       }
>     }),
> 
>@@ -242,11 +242,11 @@
>     getPageY : rwt.util.Variant.select("qx.client",
>     {
>       "mshtml" : function() {
>-        return this.getDomEvent().clientY + rwt.html.Viewport.getScrollTop(window);
>+        return Math.round( this.getDomEvent().clientY + rwt.html.Viewport.getScrollTop( window ) );
>       },
> 
>       "default" : function() {
>-        return this.getDomEvent().pageY;
>+        return Math.round( this.getDomEvent().pageY );
>       }
>     }),
> 
>#P org.eclipse.rap.rwt.jstest
>diff --git js/org/eclipse/rwt/test/tests/ShellProtocolIntegrationTest.js js/org/eclipse/rwt/test/tests/ShellProtocolIntegrationTest.js
>index 384e2e8..1e1a21f 100644
>--- js/org/eclipse/rwt/test/tests/ShellProtocolIntegrationTest.js
>+++ js/org/eclipse/rwt/test/tests/ShellProtocolIntegrationTest.js
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2011, 2012 EclipseSource and others.
>+ * Copyright (c) 2011, 2013 EclipseSource and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -611,6 +611,27 @@
>       this._disposeShell();
>     },
> 
>+    testNotifyMouseDown_FloatPointValues : function() {
>+      rwt.remote.EventUtil.setSuspended( true );
>+      var shell = this._protocolCreateShell();
>+      this._protocolListen( { "MouseDown" : true } );
>+      this._protocolSet( { "visibility" : true } );
>+      TestUtil.flush();
>+      rwt.remote.EventUtil.setSuspended( false );
>+
>+      TestUtil.click( shell, 10.4, 20.3 );
>+
>+      var message = TestUtil.getMessageObject();
>+      assertEquals( 1, message.findNotifyProperty( "w3", "MouseDown", "button" ) );
>+      assertEquals( 10, message.findNotifyProperty( "w3", "MouseDown", "x" ) );
>+      assertEquals( 20, message.findNotifyProperty( "w3", "MouseDown", "y" ) );
>+      assertNotNull( message.findNotifyProperty( "w3", "MouseDown", "time" ) );
>+      assertFalse( message.findNotifyProperty( "w3", "MouseDown", "shiftKey" ) );
>+      assertFalse( message.findNotifyProperty( "w3", "MouseDown", "ctrlKey" ) );
>+      assertFalse( message.findNotifyProperty( "w3", "MouseDown", "altKey" ) );
>+      this._disposeShell();
>+    },
>+
>     testNotifyMouseUp : function() {
>       rwt.remote.EventUtil.setSuspended( true );
>       var shell = this._protocolCreateShell();

Flags:

ivan: review+

Actions: View | Diff

Attachments on bug 408701: 231306 | 231311