Attachment 231307 Details for Bug 408694 – Fix for the test

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix for the test

Fix-JavaScript-tests-on-MacOS-Safari-6.patch (text/plain), 1.41 KB, created by Tim Buschtoens

on 2013-05-22 10:20:48 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2013-05-22 10:20:48 EDT

Size: 1.41 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>diff --git js/rwt/remote/EventUtil.js js/rwt/remote/EventUtil.js
>index 102faaa..15b9138 100644
>--- js/rwt/remote/EventUtil.js
>+++ js/rwt/remote/EventUtil.js
>@@ -106,7 +106,7 @@
> 
>     addModifierToProperties : function( properties, event ) {
>       var isMac = rwt.client.Client.getPlatform() === "mac";
>-      var commandKey = isMac && ( event ? event.metaKey : rwt.remote.EventUtil._metaKey );
>+      var commandKey = isMac && ( event ? event.metaKey : rwt.remote.EventUtil._metaKey ) === true;
>       properties.shiftKey = event ? event.shiftKey : rwt.remote.EventUtil._shiftKey;
>       properties.ctrlKey = ( event ? event.ctrlKey : rwt.remote.EventUtil._ctrlKey ) || commandKey;
>       properties.altKey = event ? event.altKey : rwt.remote.EventUtil._altKey;
>#P org.eclipse.rap.rwt.jstest
>diff --git js/org/eclipse/rwt/test/tests/GCCanvasTest.js js/org/eclipse/rwt/test/tests/GCCanvasTest.js
>index b7a55cb..bbc7422 100644
>--- js/org/eclipse/rwt/test/tests/GCCanvasTest.js
>+++ js/org/eclipse/rwt/test/tests/GCCanvasTest.js
>@@ -103,7 +103,7 @@
>       ] );
>             
>       var context = gc._context;
>-      assertTrue( context.isPointInPath( 101, 115 ) );
>+      assertTrue( context.isPointInPath( 101, 115.1 ) );
>       assertTrue( context.isPointInPath( 159, 115 ) );
>       assertTrue( context.isPointInPath( 104, 122 ) );
>       assertTrue( context.isPointInPath( 155, 122 ) );

Flags:

ivan: review+

Actions: View | Diff

Attachments on bug 408694: 231307