Attachment 231291 Details for Bug 401518 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

side-by-side-spinners.patch (text/plain), 3.63 KB, created by Ivan Furnadjiev

on 2013-05-22 02:00:35 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2013-05-22 02:00:35 EDT

Size: 3.63 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.tools.launch.rwt
>diff --git src/org/eclipse/rap/ui/internal/launch/rwt/tab/ServerSettingsSection.java src/org/eclipse/rap/ui/internal/launch/rwt/tab/ServerSettingsSection.java
>index a425dcc..3bf0bf8 100644
>--- src/org/eclipse/rap/ui/internal/launch/rwt/tab/ServerSettingsSection.java
>+++ src/org/eclipse/rap/ui/internal/launch/rwt/tab/ServerSettingsSection.java
>@@ -37,7 +37,7 @@
>     Group group = new Group( parent, SWT.NONE );
>     group.setLayoutData( new GridData( SWT.FILL, SWT.TOP, true, false ) );
>     group.setText( "Server Settings" );
>-    group.setLayout( new GridLayout( 2, false ) );
>+    group.setLayout( new GridLayout( 4, false ) );
>     cbManualPort = createCheckButton( group, "Use a fixed &port:" );
>     cbManualPort.addSelectionListener( new UpdateConfigSelectionListener() );
>     spnPort = new Spinner( group, SWT.BORDER );
>@@ -46,6 +46,7 @@
>     spnPort.setMaximum( RWTLaunchConfig.MAX_PORT_NUMBER );
>     spnPort.addModifyListener( new UpdateConfigModifyListener() );
>     cbSessionTimeout = new Button( group, SWT.CHECK );
>+    GridDataFactory.fillDefaults().indent( 50, 0 ).applyTo( cbSessionTimeout );
>     cbSessionTimeout.setText( "Session &timeout [min]:" );
>     cbSessionTimeout.addSelectionListener( new UpdateConfigSelectionListener() );
>     spnSessionTimeout = new Spinner( group, SWT.BORDER );
>@@ -57,7 +58,7 @@
>     cbContextPath.setText( "Context pat&h:" );
>     cbContextPath.addSelectionListener( new UpdateConfigSelectionListener() );
>     txtContextPath = new Text( group, SWT.BORDER | SWT.SINGLE );
>-    GridDataFactory.fillDefaults().grab( true, false ).applyTo( txtContextPath );
>+    GridDataFactory.fillDefaults().grab( true, false ).span( 3, 1 ).applyTo( txtContextPath );
>     txtContextPath.addModifyListener( new UpdateConfigModifyListener() );
>     updateEnablement();
>     setControl( group );
>#P org.eclipse.rap.tools.launch
>diff --git src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java
>index 67b5879..0f4135b 100644
>--- src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java
>+++ src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java
>@@ -301,7 +301,7 @@
>     Group group = new Group( parent, SWT.NONE );
>     group.setLayoutData( fillHorizontal.create() );
>     group.setText( LaunchMessages.MainTab_ServerSettings );
>-    group.setLayout( new GridLayout( 2, false ) );
>+    group.setLayout( new GridLayout( 4, false ) );
>     useFixedPortCheckBox = new Button( group, SWT.CHECK );
>     useFixedPortCheckBox.setText( LaunchMessages.MainTab_ManualPortConfig );
>     useFixedPortCheckBox.addSelectionListener( selectionListener );
>@@ -311,6 +311,7 @@
>     portSpinner.setMaximum( RAPLaunchConfig.MAX_PORT_NUMBER );
>     portSpinner.addModifyListener( modifyListener );
>     useSessionTimeoutCheckBox = new Button( group, SWT.CHECK );
>+    GridDataFactory.fillDefaults().indent( 50, 0 ).applyTo( useSessionTimeoutCheckBox );
>     useSessionTimeoutCheckBox.setText( LaunchMessages.MainTab_ManualTimeoutConfig );
>     useSessionTimeoutCheckBox.addSelectionListener( selectionListener );
>     sessionTimeoutSpinner = new Spinner( group, SWT.BORDER );
>@@ -322,7 +323,7 @@
>     contextPathCheckBox.setText( LaunchMessages.MainTab_ManualContextPath );
>     contextPathCheckBox.addSelectionListener( selectionListener );
>     contextPathTextField = new Text( group, SWT.BORDER | SWT.SINGLE );
>-    GridDataFactory.fillDefaults().grab( true, false ).applyTo( contextPathTextField );
>+    GridDataFactory.fillDefaults().grab( true, false ).span( 3, 1 ).applyTo( contextPathTextField );
>     contextPathTextField.addModifyListener( modifyListener );
>   }
>

Flags:

rsternberg: review+

Actions: View | Diff

Attachments on bug 401518: 231253 | 231291