Attachment 226916 Details for Bug 387234 – Patch v.0.2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch v.0.2

patch387234_201302121300.txt (text/plain), 1.66 KB, created by Szymon Ptaszkiewicz

on 2013-02-12 08:34:26 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Szymon Ptaszkiewicz

Created: 2013-02-12 08:34:26 EST

Size: 1.66 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java b/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java
>index 2024cc5..6fe2d30 100644
>--- a/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java
>+++ b/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java
>@@ -118,9 +118,8 @@
> 
> 			boolean menuChild = parent instanceof MMenu;
> 
>-			// If the parent isn't displayed who cares?
> 			if (!(parent instanceof MApplication)
>-					&& (parent == null || parent.getWidget() == null || menuChild))
>+					&& (parent == null || menuChild))
> 				return;
> 
> 			if (changedElement.isToBeRendered()) {
>diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java
>index 877e4f9..13ecc27 100644
>--- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java
>+++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java
>@@ -415,14 +415,14 @@
> 				}
> 			}
> 		} else if (parent != null) {
>+			if (window != parent) {
>+				showElementInWindow(window, parent);
>+			}
> 			// Force the element to be rendered
> 			if (!element.isToBeRendered())
> 				element.setToBeRendered(true);
> 
> 			((MElementContainer<MUIElement>) parent).setSelectedElement(element);
>-			if (window != parent) {
>-				showElementInWindow(window, parent);
>-			}
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 387234: 224810 | 226916