Attachment 225800 Details for Bug 391608 – Prototype of simpler fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Prototype of simpler fix

z.lt.patch (text/plain), 9.36 KB, created by Marc Khouzam

on 2013-01-17 22:58:15 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2013-01-17 22:58:15 EST

Size: 9.36 KB

patch

obsolete

>diff --git a/profiling/org.eclipse.linuxtools.profiling.launch/META-INF/MANIFEST.MF b/profiling/org.eclipse.linuxtools.profiling.launch/META-INF/MANIFEST.MF
>index 6f9e578..14e5e26 100644
>--- a/profiling/org.eclipse.linuxtools.profiling.launch/META-INF/MANIFEST.MF
>+++ b/profiling/org.eclipse.linuxtools.profiling.launch/META-INF/MANIFEST.MF
>@@ -8,7 +8,8 @@
>  org.eclipse.core.runtime,
>  org.eclipse.cdt.core,
>  org.eclipse.cdt.launch;bundle-version="7.0.0",
>- org.eclipse.core.filesystem;bundle-version="1.3.100"
>+ org.eclipse.core.filesystem;bundle-version="1.3.100",
>+ org.eclipse.cdt.debug.ui
> Bundle-ActivationPolicy: lazy
> Bundle-RequiredExecutionEnvironment: J2SE-1.5
> Import-Package: org.eclipse.cdt.core.model,
>diff --git a/profiling/org.eclipse.linuxtools.profiling.launch/plugin.xml b/profiling/org.eclipse.linuxtools.profiling.launch/plugin.xml
>index 7f4ebbb..6a28f55 100644
>--- a/profiling/org.eclipse.linuxtools.profiling.launch/plugin.xml
>+++ b/profiling/org.eclipse.linuxtools.profiling.launch/plugin.xml
>@@ -413,4 +413,109 @@
>                mode="linuxtools">
>          </launchMode>
>       </extension>
>+   <extension point="org.eclipse.debug.core.launchDelegates">
>+      <launchDelegate
>+            id="org.eclipse.linuxtools.profilingDelegate"
>+            type="org.eclipse.cdt.launch.applicationLaunchType"
>+            modes="profile"
>+            delegate="org.eclipse.linuxtools.internal.profiling.launch.provider.launch.ProviderLaunchConfigurationDelegate"
>+            name="ProfilingDelegate"
>+            delegateDescription="%launchDelegate.localApplication.description"
>+            sourceLocatorId="org.eclipse.cdt.debug.core.sourceLocator"
>+            sourcePathComputerId="org.eclipse.cdt.debug.core.sourcePathComputer">
>+      </launchDelegate>
>+     </extension>
>+      <extension
>+            point="org.eclipse.debug.ui.launchConfigurationTabs">
>+       
>+      <tab
>+            id="org.eclipse.cdt.cdi.launch.profileApplicationLaunch.mainTab"
>+            group="org.eclipse.cdt.launch.applicationProfileLaunchTabGroup"
>+            name="Main"
>+            class="org.eclipse.cdt.launch.ui.CMainTab">
>+        <associatedDelegate delegate="org.eclipse.linuxtools.profilingDelegate"/>
>+      </tab>
>+      <tab
>+            id="org.eclipse.cdt.cdi.launch.profileApplicationLaunch.argumentsTab"
>+            group="org.eclipse.cdt.launch.applicationProfileLaunchTabGroup"
>+            name="Arguments"
>+            class="org.eclipse.cdt.launch.ui.CArgumentsTab">
>+        <associatedDelegate delegate="org.eclipse.linuxtools.profilingDelegate"/>
>+        <placement after="org.eclipse.cdt.cdi.launch.mainTab"/>
>+      </tab>
>+      <tab
>+            id="org.eclipse.cdt.cdi.launch.profileApplicationLaunch.environmentTab"
>+            group="org.eclipse.cdt.launch.applicationProfileLaunchTabGroup"
>+            name="Environment"
>+            class="org.eclipse.debug.ui.EnvironmentTab">
>+        <associatedDelegate delegate="org.eclipse.linuxtools.profilingDelegate"/>
>+        <placement after="org.eclipse.cdt.cdi.launch.argumentsTab"/>
>+      </tab>
>+      <tab
>+            id="org.eclipse.cdt.cdi.launch.profileApplicationLaunch.commonTab"
>+            group="org.eclipse.cdt.launch.applicationProfileLaunchTabGroup"
>+            name="Common"
>+            class="org.eclipse.debug.ui.CommonTab">
>+        <associatedDelegate delegate="org.eclipse.linuxtools.profilingDelegate"/>
>+        <placement after="org.eclipse.debug.ui.environmentTab"/>
>+      </tab>
>+      <tab
>+            id="org.eclipse.cdt.cdi.launch.profileApplicationLaunch.profilingTab"
>+            group="org.eclipse.cdt.launch.applicationProfileLaunchTabGroup"
>+            name="Profiler"
>+            class="org.eclipse.linuxtools.profiling.launch.RemoteProxyCMainTab"> 
>+        <associatedDelegate delegate="org.eclipse.linuxtools.profilingDelegate"/>
>+        <placement after="org.eclipse.debug.ui.commonTab"/>
>+      </tab> 
>+      </extension>
>+      <extension
>+         point="org.eclipse.debug.ui.launchConfigurationTabGroups">
>+      <launchConfigurationTabGroup
>+            type="org.eclipse.cdt.launch.applicationLaunchType"
>+            class="org.eclipse.linuxtools.profiling.launch.PlaceHolderLaunchConfigurationTabGroup"
>+            id="org.eclipse.cdt.launch.applicationProfileLaunchTabGroup">
>+         <launchMode mode="profile"/>
>+      </launchConfigurationTabGroup>
>+      </extension>
>+         <extension
>+         point="org.eclipse.debug.ui.launchShortcuts">
>+      <shortcut
>+            label="Local C/C++ Application"
>+            icon="icons/time_obj.gif"
>+            modes="profile"
>+            class="org.eclipse.linuxtools.profiling.launch.CApplicationLaunchShortcut"
>+            id="org.eclipse.cdt.debug.ui.localCShortcut">
>+         <contextualLaunch>
>+           <enablement>
>+             <with variable="selection">
>+               <count value="1"/>
>+               <iterate>
>+                   <or>
>+                     <instanceof value="org.eclipse.cdt.core.model.IBinary"/>
>+                     <instanceof value="org.eclipse.cdt.core.model.ICProject"/>
>+                     <test
>+                           forcePluginActivation="true"
>+                           property="org.eclipse.cdt.launch.isExecutable"/>
>+                     <test
>+                           forcePluginActivation="true"
>+                           property="org.eclipse.cdt.launch.isCProject"/>
>+                     <and>
>+                       <instanceof value="org.eclipse.ui.IFileEditorInput"/>
>+                       <adapt type="org.eclipse.core.resources.IResource">
>+                         <adapt type="org.eclipse.cdt.core.model.ICElement"/>
>+                       </adapt>
>+                     </and>
>+                   </or>
>+               </iterate>
>+             </with>
>+           </enablement>
>+         </contextualLaunch>
>+         <description
>+             mode="profile"
>+             description="Profiles a local C/C++ application"/>
>+         <configurationType
>+               id="org.eclipse.cdt.launch.applicationLaunchType">
>+         </configurationType>
>+	</shortcut>
>+   </extension>
> </plugin>
>diff --git a/profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/profiling/launch/CApplicationLaunchShortcut.java b/profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/profiling/launch/CApplicationLaunchShortcut.java
>new file mode 100644
>index 0000000..eb5bcc2
>--- /dev/null
>+++ b/profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/profiling/launch/CApplicationLaunchShortcut.java
>@@ -0,0 +1,20 @@
>+/*******************************************************************************
>+ * Copyright (c) 2005, 2011 QNX Software Systems and others.
>+ * All rights reserved. This program and the accompanying materials
>+ * are made available under the terms of the Eclipse Public License v1.0
>+ * which accompanies this distribution, and is available at
>+ * http://www.eclipse.org/legal/epl-v10.html
>+ *
>+ * Contributors:
>+ *     QNX Software Systems - Initial API and implementation
>+ *     Ken Ryall (Nokia) - bug 178731
>+ *     Ken Ryall (Nokia) - bug 246201
>+ *******************************************************************************/
>+package org.eclipse.linuxtools.profiling.launch;
>+
>+
>+/**
>+ * @since 2.0
>+ */
>+public class CApplicationLaunchShortcut extends org.eclipse.cdt.debug.internal.ui.launch.CApplicationLaunchShortcut {
>+}
>diff --git a/profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/profiling/launch/PlaceHolderLaunchConfigurationTabGroup.java b/profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/profiling/launch/PlaceHolderLaunchConfigurationTabGroup.java
>new file mode 100644
>index 0000000..437d903
>--- /dev/null
>+++ b/profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/profiling/launch/PlaceHolderLaunchConfigurationTabGroup.java
>@@ -0,0 +1,32 @@
>+/*******************************************************************************
>+ * Copyright (c) 2008, 2009 Wind River Systems and others.
>+ * All rights reserved. This program and the accompanying materials
>+ * are made available under the terms of the Eclipse Public License v1.0
>+ * which accompanies this distribution, and is available at
>+ * http://www.eclipse.org/legal/epl-v10.html
>+ * 
>+ * Contributors:
>+ *     Wind River Systems - initial API and implementation
>+ *******************************************************************************/
>+package org.eclipse.linuxtools.profiling.launch;
>+
>+import org.eclipse.debug.ui.AbstractLaunchConfigurationTabGroup;
>+import org.eclipse.debug.ui.ILaunchConfigurationDialog;
>+import org.eclipse.debug.ui.ILaunchConfigurationTab;
>+
>+/**
>+ * This implementation is used where the composition of the tab group is defined
>+ * via the launchConfigurationTabGroups extension-point. Thus we just provide an
>+ * empty array of tab objects. The platform will add the ones declared in the
>+ * extension.
>+ * @since 2.0
>+ */
>+public class PlaceHolderLaunchConfigurationTabGroup extends AbstractLaunchConfigurationTabGroup {
>+	
>+    /* (non-Javadoc)
>+     * @see org.eclipse.debug.ui.ILaunchConfigurationTabGroup#createTabs(org.eclipse.debug.ui.ILaunchConfigurationDialog, java.lang.String)
>+     */
>+	public void createTabs(ILaunchConfigurationDialog dialog, String mode) {
>+        setTabs(new ILaunchConfigurationTab[0]);
>+    }
>+}
>\ No newline at end of file

Actions: View | Diff

Attachments on bug 391608: 225783 | 225784 | 225785 | 225786 | 225787 | 225800