Attachment 224998 Details for Bug 387678 – patch v.1

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch v.1

StackDropAgent.patch (text/plain), 1.29 KB, created by Piotr Aniola

on 2012-12-21 11:23:18 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Piotr Aniola

Created: 2012-12-21 11:23:18 EST

Size: 1.29 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/StackDropAgent.java b/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/StackDropAgent.java
>index 12e99b5..9f756c4 100644
>--- a/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/StackDropAgent.java
>+++ b/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/StackDropAgent.java
>@@ -223,7 +223,8 @@
> 
> 		// 'dropIndex' is now the index of the CTabItem to put ourselves before
> 		// we need to adjust this to be a model index
>-		if (dropIndex < dropCTF.getItemCount()) {
>+		int ctfItemCount = dropCTF.getItemCount();
>+		if (dropIndex < ctfItemCount) {
> 			CTabItem item = dropCTF.getItem(dropIndex);
> 			MUIElement itemModel = (MUIElement) item.getData(AbstractPartRenderer.OWNING_ME);
> 
>@@ -232,6 +233,11 @@
> 				return;
> 
> 			dropIndex = itemModel.getParent().getChildren().indexOf(itemModel);
>+			// if the item is dropped at the last position, there is
>+			// no existing item to put ourselves before
>+			// so we'll just go to the end.
>+		} else if (dropIndex == ctfItemCount) {
>+			dropIndex = dropStack.getChildren().size();
> 		}
> 
> 		if (dragElement instanceof MStackElement) {

Actions: View | Diff

Attachments on bug 387678: 220144 | 224998