Attachment 224582 Details for Bug 395785 – Patch to remove unnessary decode() call.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to remove unnessary decode() call.

RemoteSearch.patch (text/plain), 1.58 KB, created by Chris Austin

on 2012-12-11 11:45:00 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Austin

Created: 2012-12-11 11:45:00 EST

Size: 1.58 KB

patch

obsolete

>diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/SearchServlet.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/SearchServlet.java
>index fe9d253..23c82e2 100644
>--- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/SearchServlet.java
>+++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/SearchServlet.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2011 IBM Corporation and others.
>+ * Copyright (c) 2000, 2012 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -27,7 +27,6 @@
> import org.eclipse.help.internal.search.ISearchQuery;
> import org.eclipse.help.internal.search.QueryTooComplexException;
> import org.eclipse.help.internal.search.SearchQuery;
>-import org.eclipse.help.internal.util.URLCoder;
> import org.eclipse.help.internal.webapp.data.UrlUtil;
> import org.eclipse.help.internal.webapp.utils.SearchXMLGenerator;
> 
>@@ -76,7 +75,6 @@
> 		resp.setContentType("application/xml; charset=UTF-8"); //$NON-NLS-1$
> 		String phrase = req.getParameter(PARAMETER_PHRASE);
> 		if (phrase != null) {
>-		    phrase = URLCoder.decode(phrase);
> 			ISearchQuery query = new SearchQuery(phrase, false, Collections.EMPTY_LIST, locale);
> 			collector.results.clear();
> 			BaseHelpSystem.getSearchManager().search(query, collector, new NullProgressMonitor());

Actions: View | Diff

Attachments on bug 395785: 224291 | 224582