Attachment 224069 Details for Bug 395252 – Allows finishing wizard without having changed repository-name

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Allows finishing wizard without having changed repository-name

AddRepositoryWizardFinish.patch (text/plain), 3.20 KB, created by Tobias Verhoeven

on 2012-11-28 10:10:55 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Tobias Verhoeven

Created: 2012-11-28 10:10:55 EST

Size: 3.20 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.emf.ecp.ui
>diff --git src/org/eclipse/emf/ecp/wizards/page/AddRepositoryPage.java src/org/eclipse/emf/ecp/wizards/page/AddRepositoryPage.java
>index 937fbca..c71d69e 100644
>--- src/org/eclipse/emf/ecp/wizards/page/AddRepositoryPage.java
>+++ src/org/eclipse/emf/ecp/wizards/page/AddRepositoryPage.java
>@@ -15,61 +15,49 @@
> /**
>  * @author Eugen Neufeld
>  */
>-public class AddRepositoryPage extends WizardPage
>-{
>+public class AddRepositoryPage extends WizardPage {
> 
>-  /**
>-   * @param pageName
>-   */
>-  public AddRepositoryPage(String pageName, AddRepositoryComposite addRepositoryComposite)
>-  {
>-    super(pageName);
>-    this.addRepositoryComposite = addRepositoryComposite;
>-  }
>+	/**
>+	 * @param pageName
>+	 */
>+	public AddRepositoryPage(String pageName, AddRepositoryComposite addRepositoryComposite) {
>+		super(pageName);
>+		this.addRepositoryComposite = addRepositoryComposite;
>+	}
> 
>-  private AddRepositoryComposite addRepositoryComposite;
>+	private AddRepositoryComposite addRepositoryComposite;
> 
>-  /*
>-   * (non-Javadoc)
>-   * @see org.eclipse.jface.dialogs.IDialogPage#createControl(org.eclipse.swt.widgets.Composite)
>-   */
>-  public void createControl(Composite parent)
>-  {
>-    setTitle(Messages.AddRepositoryPage_PageTitle_AddRepository);
>-    setImageDescriptor(Activator.getImageDescriptor("icons/checkout_project_wiz.png")); //$NON-NLS-1$
>-    setMessage(Messages.AddRepositoryPage_PageMessage_AddRepository);
>+	/*
>+	 * (non-Javadoc)
>+	 * @see org.eclipse.jface.dialogs.IDialogPage#createControl(org.eclipse.swt.widgets.Composite)
>+	 */
>+	public void createControl(Composite parent) {
>+		setPageComplete(false);
>+		setTitle(Messages.AddRepositoryPage_PageTitle_AddRepository);
>+		setImageDescriptor(Activator.getImageDescriptor("icons/checkout_project_wiz.png")); //$NON-NLS-1$
>+		setMessage(Messages.AddRepositoryPage_PageMessage_AddRepository);
> 
>-    Composite composite = addRepositoryComposite.createUI(parent);
>-    addRepositoryComposite.setListener(new AddRepositoryChangeListener()
>-    {
>+		addRepositoryComposite.setListener(new AddRepositoryChangeListener() {
> 
>-      public void repositoryProviderChanged(ECPProvider provider)
>-      {
>-      }
>+			public void repositoryProviderChanged(ECPProvider provider) {
>+			}
> 
>-      public void repositoryNameChanged(String repositoryName)
>-      {
>-        if (repositoryName != null)
>-        {
>-          setPageComplete(true);
>-        }
>-        else
>-        {
>-          setPageComplete(false);
>-        }
>-      }
>+			public void repositoryNameChanged(String repositoryName) {
>+				if (repositoryName != null && !repositoryName.isEmpty()) {
>+					setPageComplete(true);
>+				} else {
>+					setPageComplete(false);
>+				}
>+			}
> 
>-      public void repositoryLabelChanged(String repositoryLabel)
>-      {
>-      }
>+			public void repositoryLabelChanged(String repositoryLabel) {
>+			}
> 
>-      public void repositoryDescriptionChanged(String repositoryDescription)
>-      {
>-      }
>-    });
>-
>-    setControl(composite);
>-    setPageComplete(false);
>-  }
>+			public void repositoryDescriptionChanged(String repositoryDescription) {
>+			}
>+		});
>+		Composite composite = addRepositoryComposite.createUI(parent);
>+		setControl(composite);
>+	}
> 
> }

Flags:

eneufeld: iplog+

Actions: View | Diff

Attachments on bug 395252: 224069