Attachment 222657 Details for Bug 383305 – Patch for small font in CTabFolder chevron

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for small font in CTabFolder chevron

cTabFolderChevron.patch (text/plain), 1.58 KB, created by Tristan Hume

on 2012-10-22 16:16:44 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tristan Hume

Created: 2012-10-22 16:16:44 EDT

Size: 1.58 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java b/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java
>index 5a44c25..b4410bd 100644
>--- a/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java
>+++ b/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Tristan Hume - <trishume@gmail.com> - Fix for Bug 383305 - [10.8]Font size incorrect when running in Retina
>  *******************************************************************************/
> package org.eclipse.swt.custom;
> 
>@@ -79,6 +80,8 @@
> 	static final int[] SIMPLE_BOTTOM_RIGHT_CORNER_BORDERLESS = new int[] {-4,0, -3,-1, -2,-2, -1,-3};
> 	
> 	static final RGB CLOSE_FILL = new RGB(252, 160, 160);
>+	
>+	static final int CHEVRON_COUNT_FONT_SIZE = 10;
> 	
> 	static final int BUTTON_SIZE = 16;
> 	static final int BUTTON_TRIM = 1;
>@@ -841,10 +844,10 @@
> 		// draw chevron (10x7)
> 		Display display = parent.getDisplay();
> 		Point dpi = display.getDPI();
>-		int fontHeight = 72 * 10 / dpi.y;
> 		FontData fd = parent.getFont().getFontData()[0];
>-		fd.setHeight(fontHeight);
>+		fd.setHeight(CHEVRON_COUNT_FONT_SIZE);
> 		Font f = new Font(display, fd);
>+		// get font height in pixels
> 		int fHeight = f.getFontData()[0].getHeight() * dpi.y / 72;
> 		int indent = Math.max(2, (chevronRect.height - fHeight - 4) /2);
> 		int x = chevronRect.x + 2;

Actions: View | Diff

Attachments on bug 383305: 217737 | 220391 | 220392 | 220482 | 220659 | 222051 | 222649 | 222656 | 222657 | 222658 | 222739 | 222740 | 222844 | 222846