Attachment 222330 Details for Bug 391960 – Mark pointed out that there are two places using this message and they are not consistent.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Mark pointed out that there are two places using this message and they are not consistent.

patch391960_new.txt (text/plain), 1.05 KB, created by libing wang

on 2012-10-15 14:24:30 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: libing wang

Created: 2012-10-15 14:24:30 EDT

Size: 1.05 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js b/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js
>index 3f07a57..633fc3e 100644
>--- a/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js
>+++ b/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js
>@@ -339,9 +339,8 @@
> 					if (!foundValidHit) {
> 						// only display no matches found if we have a proper name
> 						if (queryName) {
>-							var div = dojo.place("<div>"+messages["No matches found for "]+"</div>", resultsNode, "only"); //$NON-NLS-3$ //$NON-NLS-2$ //$NON-NLS-0$
>-							var b = dojo.create("b", null, div, "last"); //$NON-NLS-1$ //$NON-NLS-0$
>-							dojo.place(document.createTextNode(queryName), b, "only"); //$NON-NLS-0$
>+							var errorStr = dojo.string.substitute(messages["No matches found for ${0}"], [queryName]); 
>+							dojo.place(document.createTextNode(errorStr), resultsNode, "only"); //$NON-NLS-0$
> 							if (typeof(onResultReady) === "function") { //$NON-NLS-0$
> 								onResultReady(resultsNode);
> 							}

Actions: View

Attachments on bug 391960: 222324 | 222325 | 222330