Attachment 22126 Details for Bug 97801 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Proposed patch

patchjdtcore001.txt (text/plain), 1.83 KB, created by David Audel

on 2005-06-01 04:08:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2005-06-01 04:08:57 EDT

Size: 1.83 KB

patch

obsolete

>Index: codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java,v
>retrieving revision 1.241
>diff -u -r1.241 CompletionEngine.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	31 May 2005 09:04:02 -0000	1.241
>+++ codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	1 Jun 2005 08:08:23 -0000
>@@ -1732,10 +1732,23 @@
> 			if(!this.requestor.isIgnored(CompletionProposal.FIELD_REF)) {
> 				CompletionProposal proposal = this.createProposal(CompletionProposal.FIELD_REF, this.actualCompletionPosition);
> 				//proposal.setDeclarationSignature(null);
>-				proposal.setSignature(
>-						createNonGenericTypeSignature(
>-								CharOperation.concatWith(JAVA_LANG, '.'),
>-								CLASS));
>+				char[] signature = 
>+					createNonGenericTypeSignature(
>+						CharOperation.concatWith(JAVA_LANG, '.'),
>+						CLASS);
>+				if (this.compilerOptions.sourceLevel > ClassFileConstants.JDK1_4) {
>+					// add type argument
>+					char[] typeArgument = receiverType.signature();
>+					int oldLength = signature.length;
>+					int argumentLength = typeArgument.length;
>+					int newLength = oldLength + argumentLength + 2;
>+					System.arraycopy(signature, 0, signature = new char[newLength], 0, oldLength - 1);
>+					signature[oldLength - 1] = '<';
>+					System.arraycopy(typeArgument, 0, signature, oldLength , argumentLength);
>+					signature[newLength - 2] = '>';
>+					signature[newLength - 1] = ';';
>+				}
>+				proposal.setSignature(signature);
> 				//proposal.setDeclarationPackageName(null);
> 				//proposal.setDeclarationTypeName(null);
> 				proposal.setPackageName(CharOperation.concatWith(JAVA_LANG, '.'));

Actions: View

Attachments on bug 97801: 22126