Attachment 220805 Details for Bug 364105 – Patch for SmartPreparedStatementCache to record allocations of CachedPreparedStatements

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for SmartPreparedStatementCache to record allocations of CachedPreparedStatements

SmartPreparedStatementCache.patch (text/plain), 1.80 KB, created by András Péteri

on 2012-09-06 16:39:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: András Péteri

Created: 2012-09-06 16:39:43 EDT

Size: 1.80 KB

patch

obsolete

>diff --git a/plugins/org.eclipse.emf.cdo.server.db/src/org/eclipse/emf/cdo/server/internal/db/SmartPreparedStatementCache.java b/plugins/org.eclipse.emf.cdo.server.db/src/org/eclipse/emf/cdo/server/internal/db/SmartPreparedStatementCache.java
>index d9c4204..973bdbf 100644
>--- a/plugins/org.eclipse.emf.cdo.server.db/src/org/eclipse/emf/cdo/server/internal/db/SmartPreparedStatementCache.java
>+++ b/plugins/org.eclipse.emf.cdo.server.db/src/org/eclipse/emf/cdo/server/internal/db/SmartPreparedStatementCache.java
>@@ -119,9 +119,12 @@
>       lists[cachedStatement.getProbability().ordinal()].add(cachedStatement);
> 
>       // put into lookup table
>-      if (lookup.put(cachedStatement.getSQL(), cachedStatement) != null)
>+      CachedPreparedStatement oldCachedPreparedStatement = lookup.put(cachedStatement.getSQL(), cachedStatement);
>+
>+      if (oldCachedPreparedStatement != null)
>       {
>-        throw new ImplementationError(cachedStatement.getSQL() + " already in cache"); //$NON-NLS-1$
>+        throw new ImplementationError(
>+            cachedStatement.getSQL() + " already in cache", oldCachedPreparedStatement.getInitStackException()); //$NON-NLS-1$
>       }
> 
>       // handle capacity overflow
>@@ -245,6 +248,8 @@
> 
>     private PreparedStatement statement;
> 
>+    private Exception initStackException;
>+
>     /**
>      * DL field
>      */
>@@ -261,6 +266,8 @@
>       probability = prob;
>       statement = stmt;
>       timeStamp = System.currentTimeMillis();
>+      initStackException = new Exception("Previous cached statement was initialized here");
>+      initStackException.fillInStackTrace();
>     }
> 
>     public PreparedStatement getPreparedStatement()
>@@ -288,5 +295,10 @@
>     {
>       return probability;
>     }
>+
>+    public Exception getInitStackException()
>+    {
>+      return initStackException;
>+    }
>   }
> }

Actions: View | Diff

Attachments on bug 364105: 220804 | 220805 | 221814