Attachment 220745 Details for Bug 372092 – Proposed changes

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed changes

patch372092.patch (text/plain), 7.10 KB, created by Guy Pelletier

on 2012-09-05 14:57:54 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Guy Pelletier

Created: 2012-09-05 14:57:54 EDT

Size: 7.10 KB

patch

obsolete

>From d6347776391e683882073f517ef0d23d6fae402f Mon Sep 17 00:00:00 2001
>From: gpelletie <guy.pelletier@oracle.com>
>Date: Wed, 5 Sep 2012 14:55:22 -0400
>Subject: [PATCH] Bug 372092 - EclipseLink dynamic entity does not support
> embedded-id
>
>Existing Inherited model using single letter generics modified to expose error (metadata processing). With fix in place, error goes away and all tests (FullRegressionTestSuite and ExtendedJPATests) pass successfully.
>
>Reviewed: James Sutherland.
>---
> .../testing/models/jpa/inherited/Beer.java         |  4 ++-
> .../testing/models/jpa/inherited/Beverage.java     | 10 +++---
> .../accessors/objects/MetadataAsmFactory.java      | 40 +++++++++++++++-------
> 3 files changed, 37 insertions(+), 17 deletions(-)
>
>diff --git a/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beer.java b/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beer.java
>index 2999643..8d008a0 100644
>--- a/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beer.java
>+++ b/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beer.java
>@@ -15,6 +15,8 @@
>  *       -311395 : Multiple lifecycle callback methods for the same lifecycle event
>  *     08/11/2010-2.2 Guy Pelletier 
>  *       - 312123: JPA: Validation error during Id processing on parameterized generic OneToOne Entity relationship from MappedSuperclass
>+ *     10/05/2012-2.4.1 Guy Pelletier 
>+ *       - 373092: Exceptions using generics, embedded key and entity inheritance
>  ******************************************************************************/  
> package org.eclipse.persistence.testing.models.jpa.inherited;
> 
>@@ -37,7 +39,7 @@ import java.sql.Timestamp;
> 
> @MappedSuperclass
> @ExistenceChecking(CHECK_CACHE)
>-public class Beer<G, H, I> extends Beverage<G> {
>+public class Beer<PK, H, I> extends Beverage<PK> {
>     private Timestamp version;
>     private H alcoholContent;
>     private BeerConsumer beerConsumer;
>diff --git a/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beverage.java b/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beverage.java
>index 3db118a..fe0c489 100644
>--- a/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beverage.java
>+++ b/jpa/eclipselink.jpa.test/src/org/eclipse/persistence/testing/models/jpa/inherited/Beverage.java
>@@ -13,6 +13,8 @@
>  *       - 232975: Failure when attribute type is generic
>  *     07/15/2010-2.2 Guy Pelletier 
>  *       -311395 : Multiple lifecycle callback methods for the same lifecycle event
>+ *     10/05/2012-2.4.1 Guy Pelletier 
>+ *       - 373092: Exceptions using generics, embedded key and entity inheritance
>  ******************************************************************************/  
> package org.eclipse.persistence.testing.models.jpa.inherited;
> 
>@@ -24,10 +26,10 @@ import javax.persistence.MappedSuperclass;
> import static javax.persistence.GenerationType.*;
> 
> @MappedSuperclass
>-public class Beverage<T> {
>+public class Beverage<PK> {
>     public static int BEVERAGE_POST_PERSIST_COUNT = 0;
>     
>-    private T id;
>+    private PK id;
>     
>     public Beverage() {}
>     
>@@ -39,11 +41,11 @@ public class Beverage<T> {
>         pkColumnName="SEQ_NAME", 
>         valueColumnName="SEQ_COUNT",
>         pkColumnValue="BEVERAGE_SEQ")
>-    public T getId() {
>+    public PK getId() {
>         return id;
>     }
>     
>-    public void setId(T id) {
>+    public void setId(PK id) {
>         this.id = id;
>     }
>     
>diff --git a/jpa/org.eclipse.persistence.jpa/src/org/eclipse/persistence/internal/jpa/metadata/accessors/objects/MetadataAsmFactory.java b/jpa/org.eclipse.persistence.jpa/src/org/eclipse/persistence/internal/jpa/metadata/accessors/objects/MetadataAsmFactory.java
>index 7638f6e..6c9c0ec 100644
>--- a/jpa/org.eclipse.persistence.jpa/src/org/eclipse/persistence/internal/jpa/metadata/accessors/objects/MetadataAsmFactory.java
>+++ b/jpa/org.eclipse.persistence.jpa/src/org/eclipse/persistence/internal/jpa/metadata/accessors/objects/MetadataAsmFactory.java
>@@ -1,5 +1,3 @@
>-package org.eclipse.persistence.internal.jpa.metadata.accessors.objects;
>-
> /*******************************************************************************
>  * Copyright (c) 1998, 2010 Oracle, Hans Harz, Andrew Rustleund. All rights reserved.
>  * This program and the accompanying materials are made available under the 
>@@ -17,7 +15,11 @@ package org.eclipse.persistence.internal.jpa.metadata.accessors.objects;
>  *           DatabaseSessionImpl.initializeDescriptors because @MapKey Annotation is not found.
>  *     04/21/2011-2.3 dclarke: Upgraded to support ASM 3.3.1
>  *     08/10/2011-2.3 Lloyd Fernandes : Bug 336133 - Validation error during processing on parameterized generic OneToMany Entity relationship from MappedSuperclass
>+ *     10/05/2012-2.4.1 Guy Pelletier 
>+ *       - 373092: Exceptions using generics, embedded key and entity inheritance
>  ******************************************************************************/
>+package org.eclipse.persistence.internal.jpa.metadata.accessors.objects;
>+
> import java.io.IOException;
> import java.io.InputStream;
> import java.util.ArrayList;
>@@ -516,16 +518,30 @@ public class MetadataAsmFactory extends MetadataFactory {
>                     }
>                 } else {
>                     // Is a generic type variable.
>-                    arguments.add(new String(new char[] { next }));
>-                    if((index+1) < length) {
>-                       if(desc.charAt(index+1)==':') {
>-                           isGenericTyped=true;
>-                           index ++;
>-                           arguments.add(":");
>-                           if(desc.charAt(index+1)==':') {
>-                               index ++;
>-                           }
>-                       }
>+                    int start = index;
>+                    int end = start;
>+                    
>+                    char myNext = next;
>+                    
>+                    while (':' != myNext && end < length - 1 && '(' != myNext && ')' != myNext && '<' != myNext && '>' != myNext && ';' != myNext) {
>+                        end++;
>+                        myNext = chars[end];
>+                    }
>+                    
>+                    if (myNext == ':') {
>+                        arguments.add(desc.substring(start, end));
>+                        isGenericTyped=true;
>+                        index = end;
>+                        arguments.add(":");
>+                        if(desc.charAt(index+1)==':') {
>+                            index ++;
>+                        }
>+                    } else if (myNext == ';' && next == 'T') {
>+                        arguments.add(new String(new char[] { next }));
>+                        arguments.add(desc.substring(start+1, end));
>+                        index = end - 1;
>+                    } else {
>+                        arguments.add(new String(new char[] { next }));
>                     }
>                 }
>             }
>-- 
>1.7.11.msysgit.1
>

Actions: View | Diff

Attachments on bug 372092: 211316 | 219268 | 220745 | 220798