Attachment 220164 Details for Bug 387611 – Possible fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Possible fix

387611.patch (text/plain), 1.62 KB, created by Thomas Watson

on 2012-08-22 15:55:40 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Watson

Created: 2012-08-22 15:55:40 EDT

Size: 1.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.equinox.simpleconfigurator
>diff --git src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
>index 06e2595..bdee9d9 100644
>--- src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
>+++ src/org/eclipse/equinox/internal/simpleconfigurator/ConfigApplier.java
>@@ -195,10 +195,20 @@
> 			if (current == null) {
> 				try {
> 					current = manipulatingContext.installBundle(bundleLocation);
>-					if (!version.equals(current.getVersion()) || !symbolicName.equals(current.getSymbolicName()))
>-						// can happen if, for example, the new version of the bundle is installed
>-						// to the same bundle location as the old version
>-						current.update();
>+					if (symbolicName != null && version != null) {
>+						Version v;
>+						try {
>+							v = new Version(version);
>+							if (!symbolicName.equals(current.getSymbolicName()) || !v.equals(current.getVersion())) {
>+								// can happen if, for example, the new version of the bundle is installed
>+								// to the same bundle location as the old version
>+								current.update();
>+							}
>+						} catch (IllegalArgumentException e) {
>+							// invalid version string; should log
>+							e.printStackTrace();
>+						}
>+					}
> 
> 					if (Activator.DEBUG)
> 						System.out.println("installed bundle:" + finalList[i]); //$NON-NLS-1$
>@@ -307,6 +317,8 @@
> 				continue;
> 			if (packageAdminService.getBundleType(bundle) == PackageAdmin.BUNDLE_TYPE_FRAGMENT)
> 				continue;
>+			if (bundle.getBundleId() == 0)
>+				continue;
> 
> 			try {
> 				bundle.start();

Actions: View | Diff

Attachments on bug 387611: 220164