Attachment 217562 Details for Bug 378494 – valgrind: Get inputStream before calling waitFor method

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] valgrind: Get inputStream before calling waitFor method

0001-valgrind-Get-inputStream-before-calling-waitFor-meth.patch (text/plain), 1.40 KB, created by Otavio Pontes

on 2012-06-19 14:04:16 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Otavio Pontes

Created: 2012-06-19 14:04:16 EDT

Size: 1.40 KB

patch

obsolete

>From 4c68f671d1585b09524c2902cc784dbab352a5e5 Mon Sep 17 00:00:00 2001
>From: Otavio Pontes <obusatto@linux.vnet.ibm.com>
>Date: Tue, 19 Jun 2012 14:57:40 -0300
>Subject: [PATCH] valgrind: Get inputStream before calling waitFor method
>
>---
> .../internal/valgrind/core/ValgrindCommand.java    |    9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java b/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java
>index 4e8c77c..c8012c2 100644
>--- a/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java
>+++ b/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java
>@@ -76,13 +76,16 @@ public class ValgrindCommand {
> 
> 	protected void readIntoBuffer(StringBuffer out, Process p) throws IOException {
> 		boolean success;
>-		InputStream in;
>+		InputStream in, err, input;
> 		try {
>+			//We need to get the inputs before calling waitFor
>+			input = p.getInputStream();
>+			err =  p.getErrorStream();
> 			if (success = (p.waitFor() == 0)) {
>-				in = p.getInputStream();
>+				in = input;
> 			}
> 			else {
>-				in = p.getErrorStream();
>+				in = err;
> 			}
> 			int ch;
> 			while ((ch = in.read()) != -1) {
>-- 
>1.7.1
>

Flags:

obusatto: iplog+

Actions: View | Diff

Attachments on bug 378494: 215063 | 215989 | 215990 | 216600 | 217547 | 217562 | 217688 | 217689