Attachment 217176 Details for Bug 382124 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

PR382124.patch (text/plain), 1.81 KB, created by Silenio Quarti

on 2012-06-11 14:21:11 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Silenio Quarti

Created: 2012-06-11 14:21:11 EDT

Size: 1.81 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.editor/web/orion/textview/textView.js b/bundles/org.eclipse.orion.client.editor/web/orion/textview/textView.js
>index f231d6b..75fff84 100644
>--- a/bundles/org.eclipse.orion.client.editor/web/orion/textview/textView.js
>+++ b/bundles/org.eclipse.orion.client.editor/web/orion/textview/textView.js
>@@ -4416,7 +4416,13 @@
> 				handlers.push({target: topNode, type: "drop", handler: function(e) { return self._handleDrop(e);}}); //$NON-NLS-0$
> 				handlers.push({target: this._clientDiv, type: isFirefox ? "DOMMouseScroll" : "mousewheel", handler: function(e) { return self._handleMouseWheel(e); }}); //$NON-NLS-1$ //$NON-NLS-0$
> 				if (isFirefox && !isWindows) {
>-					handlers.push({target: this._clientDiv, type: "DOMCharacterDataModified", handler: function (e) { return self._handleDataModified(e); }}); //$NON-NLS-0$
>+					var MutationObserver = window.MutationObserver || window.MozMutationObserver;
>+					if (MutationObserver) {
>+						this._mutationObserver = new MutationObserver(function(mutations) { self._handleDataModified(mutations); });
>+						this._mutationObserver.observe(clientDiv, {subtree: true, characterData: true});
>+					} else {
>+						handlers.push({target: this._clientDiv, type: "DOMCharacterDataModified", handler: function (e) { return self._handleDataModified(e); }}); //$NON-NLS-0$
>+					}
> 				}
> 				if (this._overlayDiv) {
> 					handlers.push({target: this._overlayDiv, type: "mousedown", handler: function(e) { return self._handleMouseDown(e);}}); //$NON-NLS-0$
>@@ -5264,6 +5270,10 @@
> 				removeHandler(h.target, h.type, h.handler);
> 			}
> 			this._handlers = null;
>+			if (this._mutationObserver) {
>+				this._mutationObserver.disconnect();
>+				this._mutationObserver = null;
>+			}
> 		},
> 		_updateDOMSelection: function () {
> 			if (this._ignoreDOMSelection) { return; }

Flags:

mihai.sucan: review+

Actions: View | Diff

Attachments on bug 382124: 217176