Attachment #215728 for bug #375409

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

View | Details | Raw Unified | Return to bug 375409
Collapse All | Expand All

Lines 81-87 Link Here

(-)a/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/BatchCompilerTest.java (-5 / +155 lines)
81	"}\n";	81	"}\n";
82		82
83	static {	83	static {
84	// TESTS_NAMES = new String[] { "test315_warn_options_a" };	84	// TESTS_NAMES = new String[] { "testBug375409" };
85	// TESTS_NUMBERS = new int[] { 306 };	85	// TESTS_NUMBERS = new int[] { 306 };
86	// TESTS_RANGE = new int[] { 298, -1 };	86	// TESTS_RANGE = new int[] { 298, -1 };
87	}	87	}
Lines 1734-1748 Link Here
1734	" intfAnnotation + annotation type used as super interface\n" +	1734	" intfAnnotation + annotation type used as super interface\n" +
1735	" intfNonInherited + interface non-inherited method compatibility\n" +	1735	" intfNonInherited + interface non-inherited method compatibility\n" +
1736	" intfRedundant find redundant superinterfaces\n" +	1736	" intfRedundant find redundant superinterfaces\n" +
		1737	" invalidJavadoc all warnings for malformed javadoc tags\n" +
		1738	" invalidJavadocTag validate javadoc tag arguments\n" +
		1739	" invalidJavadocTagDep validate deprecated references in javadoc tag args\n" +
		1740	" invalidJavadocTagNotVisible validate non-visible references in javadoc\n" +
		1741	" tag args\n" +
		1742	" invalidJavadocVisibility(<visibility>) specify visibility modifier\n" +
		1743	" for malformed javadoc tag warnings\n" +
1737	" javadoc invalid javadoc\n" +	1744	" javadoc invalid javadoc\n" +
1738	" localHiding local variable hiding another variable\n" +	1745	" localHiding local variable hiding another variable\n" +
1739	" maskedCatchBlock + hidden catch block\n" +	1746	" maskedCatchBlock + hidden catch block\n" +
		1747	" missingJavadocTags missing Javadoc tags\n" +
		1748	" missingJavadocTagsOverriding missing Javadoc tags in overriding methods\n" +
		1749	" missingJavadocTagsMethod missing Javadoc tags for method type parameter\n" +
		1750	" missingJavadocTagsVisibility(<visibility>) specify visibility modifier\n" +
		1751	" for missing javadoc tags warnings\n" +
		1752	" missingJavadocComments missing Javadoc comments\n" +
		1753	" missingJavadocCommentsOverriding missing Javadoc tags in overriding\n" +
		1754	" methods\n" +
		1755	" missingJavadocCommentsVisibility(<visibility>) specify visibility\n" +
		1756	" modifier for missing javadoc comments warnings\n" +
1740	" nls string literal lacking non-nls tag //$NON-NLS-<n>$\n" +	1757	" nls string literal lacking non-nls tag //$NON-NLS-<n>$\n" +
1741	" noEffectAssign + assignment without effect\n" +	1758	" noEffectAssign + assignment without effect\n" +
1742	" null potential missing or redundant null check\n" +	1759	" null potential missing or redundant null check\n" +
1743	" nullAnnot(<annot. names separated by \|>) + annotation based null analysis,\n" +	1760	" nullAnnot(<annot. names separated by \|>) + annotation based null analysis,\n" +
1744	" nullable\|nonnull\|nonnullbydefault annotation types\n" +	1761	" nullable\|nonnull\|nonnullbydefault annotation types\n" +
1745	" optionally specified using fully qualified names\n" +	1762	" optionally specified using fully qualified names\n" +
1746	" nullDereference + missing null check\n" +	1763	" nullDereference + missing null check\n" +
1747	" over-ann missing @Override annotation (superclass)\n" +	1764	" over-ann missing @Override annotation (superclass)\n" +
1748	" paramAssign assignment to a parameter\n" +	1765	" paramAssign assignment to a parameter\n" +
Lines 1758-1764 Link Here
1758	" super overriding a method without making a super invocation\n" +	1775	" super overriding a method without making a super invocation\n" +
1759	" suppress + enable @SuppressWarnings\n" +	1776	" suppress + enable @SuppressWarnings\n" +
1760	" When used with -err:, it can also silent optional\n" +	1777	" When used with -err:, it can also silent optional\n" +
1761	" errors and warnings\n" +	1778	" errors and warnings\n" +
1762	" switchDefault + switch statement lacking a default case\n" +	1779	" switchDefault + switch statement lacking a default case\n" +
1763	" syncOverride missing synchronized in synchr. method override\n" +	1780	" syncOverride missing synchronized in synchr. method override\n" +
1764	" syntheticAccess synthetic access for innerclass\n" +	1781	" syntheticAccess synthetic access for innerclass\n" +
Lines 1777-1784 Link Here
1777	" unusedImport + unused import declaration\n" +	1794	" unusedImport + unused import declaration\n" +
1778	" unusedLabel + unused label\n" +	1795	" unusedLabel + unused label\n" +
1779	" unusedLocal + unread local variable\n" +	1796	" unusedLocal + unread local variable\n" +
		1797	" unusedParam unused parameter\n" +
		1798	" unusedParamOverriding unused parameter for overriding method\n" +
		1799	" unusedParamImplementing unused parameter for implementing method\n" +
		1800	" unusedParamIncludeDoc unused parameter documented in comment tag\n" +
1780	" unusedPrivate + unused private member declaration\n" +	1801	" unusedPrivate + unused private member declaration\n" +
1781	" unusedThrown unused declared thrown exception\n" +	1802	" unusedThrown unused declared thrown exception\n" +
		1803	" unusedThrown unused declared thrown exception, overriding method\n" +
		1804	" unusedThrownIncludeDocComment unused declared thrown exception,\n" +
		1805	" documented in a comment tag\n" +
		1806	" unusedThrownExemptExceptionThrowable unused declared thrown exception,\n" +
		1807	" exempt Exception and Throwable\n" +
1782	" unusedTypeArgs + unused type arguments for method and constructor\n" +	1808	" unusedTypeArgs + unused type arguments for method and constructor\n" +
1783	" uselessTypeCheck unnecessary cast/instanceof operation\n" +	1809	" uselessTypeCheck unnecessary cast/instanceof operation\n" +
1784	" varargsCast + varargs argument need explicit cast\n" +	1810	" varargsCast + varargs argument need explicit cast\n" +
Lines 13178-13181 Link Here
13178	"1 problem (1 warning)",	13204	"1 problem (1 warning)",
13179	true);	13205	true);
13180	}	13206	}
		13207
		13208	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=375409
		13209	public void testBug375409a() {
		13210	this.runConformTest(
		13211	new String[] {
		13212	"p/X.java",
		13213	"package p;\n" +
		13214	"public class X {\n" +
		13215	"/** \n" +
		13216	"* Description {@see String}, {@category cat}\n" +
		13217	"* @param a\n" +
		13218	"*/\n" +
		13219	"public void foo(int i) {}}\n"
		13220	},
		13221	"\"" + OUTPUT_DIR + File.separator + "p" + File.separator + "X.java\""
		13222	+ " -sourcepath \"" + OUTPUT_DIR + "\""
		13223	+ " -1.5"
		13224	+ " -warn:invalidJavadoc -proc:none -d \"" + OUTPUT_DIR + "\"",
		13225	"",
		13226	"----------\n" +
		13227	"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/X.java (at line 4)\n" +
		13228	" * Description {@see String}, {@category cat}\n" +
		13229	" ^^^\n" +
		13230	"Javadoc: Unexpected tag\n" +
		13231	"----------\n" +
		13232	"2. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/X.java (at line 4)\n" +
		13233	" * Description {@see String}, {@category cat}\n" +
		13234	" ^^^^^^^^\n" +
		13235	"Javadoc: Unexpected tag\n" +
		13236	"----------\n" +
		13237	"3. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/X.java (at line 5)\n" +
		13238	" * @param a\n" +
		13239	" ^\n" +
		13240	"Javadoc: Parameter a is not declared\n" +
		13241	"----------\n" +
		13242	"3 problems (3 warnings)",
		13243	true);
		13244	}
		13245	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=375409
		13246	public void testBug375409b() {
		13247	this.runConformTest(
		13248	new String[] {
		13249	"p/X.java",
		13250	"package p;\n" +
		13251	"public class X {\n" +
		13252	"/** \n" +
		13253	"* Description {@see String}, {@category cat}\n" +
		13254	"* @param a\n" +
		13255	"*/\n" +
		13256	"public void foo(int i) {}}\n"
		13257	},
		13258	"\"" + OUTPUT_DIR + File.separator + "p" + File.separator + "X.java\""
		13259	+ " -sourcepath \"" + OUTPUT_DIR + "\""
		13260	+ " -1.5"
		13261	+ " -warn:missingJavadocTags,missingJavadocTagsVisibility(public) -proc:none -d \"" + OUTPUT_DIR + "\"",
		13262	"",
		13263	"----------\n" +
		13264	"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/X.java (at line 7)\n" +
		13265	" public void foo(int i) {}}\n" +
		13266	" ^\n" +
		13267	"Javadoc: Missing tag for parameter i\n" +
		13268	"----------\n" +
		13269	"1 problem (1 warning)",
		13270	true);
13271	}
13272	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=375409
13273	public void testBug375409c() {
13274	this.runConformTest(
13275	new String[] {
13276	"p/X.java",
13277	"package p;\n" +
13278	"public class X {\n" +
13279	"/** \n" +
13280	"* Description {@see String}, {@category cat}\n" +
13281	"* @param a\n" +
13282	"*/\n" +
13283	"public void foo(int i) {}}\n"
13284	},
13285	"\"" + OUTPUT_DIR + File.separator + "p" + File.separator + "X.java\""
13286	+ " -sourcepath \"" + OUTPUT_DIR + "\""
13287	+ " -1.5"
13288	+ " -warn:missingJavadocComments -proc:none -d \"" + OUTPUT_DIR + "\"",
13289	"",
13290	"----------\n" +
13291	"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/X.java (at line 2)\n" +
13292	" public class X {\n" +
13293	" ^\n" +
13294	"Javadoc: Missing comment for public declaration\n" +
13295	"----------\n" +
13296	"1 problem (1 warning)",
13297	true);
13298	}
13299	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=375409
13300	public void testBug375409d() {
13301	this.runConformTest(
13302	new String[] {
13303	"p/X.java",
13304	"package p;\n" +
13305	"public class X {\n" +
13306	"/** \n" +
13307	"* Description {@see String}, {@category cat}\n" +
13308	"* @param a\n" +
13309	"*/\n" +
13310	"void foo(int i) {}\n" +
13311	"/** \n" +
13312	"* Description {@see String}, {@category cat}\n" +
13313	"* @param a\n" +
13314	"*/\n" +
13315	"public void foo2(int i2) {}}\n"
13316	},
13317	"\"" + OUTPUT_DIR + File.separator + "p" + File.separator + "X.java\""
13318	+ " -sourcepath \"" + OUTPUT_DIR + "\""
13319	+ " -1.5"
13320	+ " -warn:missingJavadocTags,missingJavadocTagsVisibility(public) -proc:none -d \"" + OUTPUT_DIR + "\"",
13321	"",
13322	"----------\n" +
13323	"1. WARNING in ---OUTPUT_DIR_PLACEHOLDER---/p/X.java (at line 12)\n" +
13324	" public void foo2(int i2) {}}\n" +
13325	" ^^\n" +
13326	"Javadoc: Missing tag for parameter i2\n" +
13327	"----------\n" +
13328	"1 problem (1 warning)",
13329	true);
13330	}
13181	}	13331	}




						CompilerOptions.OPTION_IncludeNullInfoFromAsserts,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("invalidJavadoc")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportInvalidJavadoc, severity, isEnabling);
				this.options.put(
					CompilerOptions.OPTION_ReportInvalidJavadocTags,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				this.options.put(
					CompilerOptions.OPTION_ReportInvalidJavadocTagsDeprecatedRef,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				this.options.put(
					CompilerOptions.OPTION_ReportInvalidJavadocTagsNotVisibleRef,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				if (isEnabling) {
					this.options.put(
							CompilerOptions.OPTION_DocCommentSupport,
							CompilerOptions.ENABLED);
					this.options.put(
						CompilerOptions.OPTION_ReportInvalidJavadocTagsVisibility,
						CompilerOptions.PRIVATE);
				}
				return;
			} else if (token.equals("invalidJavadocTag")) { //$NON-NLS-1$
				this.options.put(
					CompilerOptions.OPTION_ReportInvalidJavadocTags,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("invalidJavadocTagDep")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportInvalidJavadocTagsDeprecatedRef,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("invalidJavadocTagNotVisible")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportInvalidJavadocTagsNotVisibleRef,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.startsWith("invalidJavadocTagVisibility")) { //$NON-NLS-1$
				int start = token.indexOf('(');
				int end = token.indexOf(')');
				String visibility = null;
				if (isEnabling && start >= 0 && end >= 0 && start < end){
					visibility = token.substring(start+1, end).trim();
				}
				if (visibility != null && visibility.equals(CompilerOptions.PUBLIC)
						|| visibility.equals(CompilerOptions.PRIVATE)
						|| visibility.equals(CompilerOptions.PROTECTED)
						|| visibility.equals(CompilerOptions.DEFAULT)) {
					this.options.put(
							CompilerOptions.OPTION_ReportInvalidJavadocTagsVisibility,
							visibility);
					return;
				} else {
					throw new IllegalArgumentException(this.bind("configure.invalidJavadocTagVisibility", token)); //$NON-NLS-1$
				}
			}
			break;
		case 'j' :
			if (token.equals("javadoc")) {//$NON-NLS-1$

			if (token.equals("maskedCatchBlock") || token.equals("maskedCatchBlocks")/*backward compatible*/) { //$NON-NLS-1$ //$NON-NLS-2$
				setSeverity(CompilerOptions.OPTION_ReportHiddenCatchBlock, severity, isEnabling);
				return;
			} else if (token.equals("missingJavadocTags")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportMissingJavadocTags, severity, isEnabling);
				this.options.put(
					CompilerOptions.OPTION_ReportMissingJavadocTagsOverriding,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				this.options.put(
					CompilerOptions.OPTION_ReportMissingJavadocTagsMethodTypeParameters,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				if (isEnabling) {
					this.options.put(
							CompilerOptions.OPTION_DocCommentSupport,
							CompilerOptions.ENABLED);
					this.options.put(
						CompilerOptions.OPTION_ReportMissingJavadocTagsVisibility,
						CompilerOptions.PRIVATE);
				}
				return;
			} else if (token.equals("missingJavadocTagsOverriding")) { //$NON-NLS-1$
				this.options.put(
					CompilerOptions.OPTION_ReportMissingJavadocTagsOverriding,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("missingJavadocTagsMethod")) { //$NON-NLS-1$
				this.options.put(
					CompilerOptions.OPTION_ReportMissingJavadocTagsMethodTypeParameters,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.startsWith("missingJavadocTagsVisibility")) { //$NON-NLS-1$
				int start = token.indexOf('(');
				int end = token.indexOf(')');
				String visibility = null;
				if (isEnabling && start >= 0 && end >= 0 && start < end){
					visibility = token.substring(start+1, end).trim();
				}
				if (visibility != null && visibility.equals(CompilerOptions.PUBLIC)
						|| visibility.equals(CompilerOptions.PRIVATE)
						|| visibility.equals(CompilerOptions.PROTECTED)
						|| visibility.equals(CompilerOptions.DEFAULT)) {
					this.options.put(
							CompilerOptions.OPTION_ReportMissingJavadocTagsVisibility,
							visibility);
					return;
				} else {
					throw new IllegalArgumentException(this.bind("configure.missingJavadocTagsVisibility", token)); //$NON-NLS-1$
				}
			} else if (token.equals("missingJavadocComments")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportMissingJavadocComments, severity, isEnabling);
				this.options.put(
					CompilerOptions.OPTION_ReportMissingJavadocCommentsOverriding,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				if (isEnabling) {
					this.options.put(
							CompilerOptions.OPTION_DocCommentSupport,
							CompilerOptions.ENABLED);
					this.options.put(
						CompilerOptions.OPTION_ReportMissingJavadocCommentsVisibility,
						CompilerOptions.PRIVATE);
				}
				return;
			} else if (token.equals("missingJavadocCommentsOverriding")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportMissingJavadocComments, severity, isEnabling);
				this.options.put(
					CompilerOptions.OPTION_ReportMissingJavadocCommentsOverriding,
					isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.startsWith("missingJavadocCommentsVisibility")) { //$NON-NLS-1$
				int start = token.indexOf('(');
				int end = token.indexOf(')');
				String visibility = null;
				if (isEnabling && start >= 0 && end >= 0 && start < end){
					visibility = token.substring(start+1, end).trim();
				}
				if (visibility != null && visibility.equals(CompilerOptions.PUBLIC)
						|| visibility.equals(CompilerOptions.PRIVATE)
						|| visibility.equals(CompilerOptions.PROTECTED)
						|| visibility.equals(CompilerOptions.DEFAULT)) {
					this.options.put(
							CompilerOptions.OPTION_ReportMissingJavadocCommentsVisibility,
							visibility);
					return;
				} else {
					throw new IllegalArgumentException(this.bind("configure.missingJavadocCommentsVisibility", token)); //$NON-NLS-1$
				}
			}
			break;
		case 'n' :

			} else if (token.equals("unusedThrown")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportUnusedDeclaredThrownException, severity, isEnabling);
				return;
			} else if (token.equals("unusedThrownWhenOverriding")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportUnusedDeclaredThrownExceptionWhenOverriding,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("unusedThrownIncludeDocComment")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportUnusedDeclaredThrownExceptionIncludeDocCommentReference,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("unusedThrownExemptExceptionThrowable")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("unqualifiedField") || token.equals("unqualified-field-access")) { //$NON-NLS-1$ //$NON-NLS-2$
				setSeverity(CompilerOptions.OPTION_ReportUnqualifiedFieldAccess, severity, isEnabling);
				return;

				setSeverity(CompilerOptions.OPTION_ReportUnusedTypeArgumentsForMethodInvocation, severity, isEnabling);
				setSeverity(CompilerOptions.OPTION_ReportRedundantSpecificationOfTypeArguments, severity, isEnabling);
				return;
			} else if (token.equals("unusedParam")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportUnusedParameter, severity, isEnabling);
				return;
			} else if (token.equals("unusedParamIncludeDoc")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportUnusedParameterIncludeDocCommentReference,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("unusedParamOverriding")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportUnusedParameterWhenOverridingConcrete,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			} else if (token.equals("unusedParamImplementing")) { //$NON-NLS-1$
				this.options.put(
						CompilerOptions.OPTION_ReportUnusedParameterWhenImplementingAbstract,
						isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
				return;
			}  else if (token.equals("unusedTypeArgs")) { //$NON-NLS-1$
				setSeverity(CompilerOptions.OPTION_ReportUnusedTypeArgumentsForMethodInvocation, severity, isEnabling);
				setSeverity(CompilerOptions.OPTION_ReportRedundantSpecificationOfTypeArguments, severity, isEnabling);
				return;

Lines 320-329 Link Here

(-)a/org.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/messages.properties (-1 / +26 lines)
320	\ intfAnnotation + annotation type used as super interface\n\	320	\ intfAnnotation + annotation type used as super interface\n\
321	\ intfNonInherited + interface non-inherited method compatibility\n\	321	\ intfNonInherited + interface non-inherited method compatibility\n\
322	\ intfRedundant find redundant superinterfaces\n\	322	\ intfRedundant find redundant superinterfaces\n\
		323	\ invalidJavadoc all warnings for malformed javadoc tags\n\
		324	\ invalidJavadocTag validate javadoc tag arguments\n\
		325	\ invalidJavadocTagDep validate deprecated references in javadoc tag args\n\
		326	\ invalidJavadocTagNotVisible validate non-visible references in javadoc\n\
		327	\ tag args\n\
		328	\ invalidJavadocVisibility(<visibility>) specify visibility modifier\n\
		329	\ for malformed javadoc tag warnings\n\
323	\ javadoc invalid javadoc\n\	330	\ javadoc invalid javadoc\n\
324	\ localHiding local variable hiding another variable\n\	331	\ localHiding local variable hiding another variable\n\
325	\ maskedCatchBlock + hidden catch block\n\	332	\ maskedCatchBlock + hidden catch block\n\
326	\ missingJavadocTags missing Javadoc tags\n\	333	\ missingJavadocTags missing Javadoc tags\n\
		334	\ missingJavadocTagsOverriding missing Javadoc tags in overriding methods\n\
		335	\ missingJavadocTagsMethod missing Javadoc tags for method type parameter\n\
		336	\ missingJavadocTagsVisibility(<visibility>) specify visibility modifier\n\
		337	\ for missing javadoc tags warnings\n\
		338	\ missingJavadocComments missing Javadoc comments\n\
		339	\ missingJavadocCommentsOverriding missing Javadoc tags in overriding\n\
		340	\ methods\n\
		341	\ missingJavadocCommentsVisibility(<visibility>) specify visibility\n\
		342	\ modifier for missing javadoc comments warnings\n\
327	\ nls string literal lacking non-nls tag //$NON-NLS-<n>$\n\	343	\ nls string literal lacking non-nls tag //$NON-NLS-<n>$\n\
328	\ noEffectAssign + assignment without effect\n\	344	\ noEffectAssign + assignment without effect\n\
329	\ null potential missing or redundant null check\n\	345	\ null potential missing or redundant null check\n\
Lines 364-371 Link Here
364	\ unusedImport + unused import declaration\n\	380	\ unusedImport + unused import declaration\n\
365	\ unusedLabel + unused label\n\	381	\ unusedLabel + unused label\n\
366	\ unusedLocal + unread local variable\n\	382	\ unusedLocal + unread local variable\n\
		383	\ unusedParam unused parameter\n\
		384	\ unusedParamOverriding unused parameter for overriding method\n\
		385	\ unusedParamImplementing unused parameter for implementing method\n\
		386	\ unusedParamIncludeDoc unused parameter documented in comment tag\n\
367	\ unusedPrivate + unused private member declaration\n\	387	\ unusedPrivate + unused private member declaration\n\
368	\ unusedThrown unused declared thrown exception\n\	388	\ unusedThrown unused declared thrown exception\n\
		389	\ unusedThrown unused declared thrown exception, overriding method\n\
		390	\ unusedThrownIncludeDocComment unused declared thrown exception,\n\
		391	\ documented in a comment tag\n\
		392	\ unusedThrownExemptExceptionThrowable unused declared thrown exception,\n\
		393	\ exempt Exception and Throwable\n\
369	\ unusedTypeArgs + unused type arguments for method and constructor\n\	394	\ unusedTypeArgs + unused type arguments for method and constructor\n\
370	\ uselessTypeCheck unnecessary cast/instanceof operation\n\	395	\ uselessTypeCheck unnecessary cast/instanceof operation\n\
371	\ varargsCast + varargs argument need explicit cast\n\	396	\ varargsCast + varargs argument need explicit cast\n\

Return to bug 375409

Lines 3446-3452 Link Here

(-)a/org.eclipse.jdt.core/batch/org/eclipse/jdt/internal/compiler/batch/Main.java (-2 / +171 lines)
3446	CompilerOptions.OPTION_IncludeNullInfoFromAsserts,	3446	CompilerOptions.OPTION_IncludeNullInfoFromAsserts,
3447	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);	3447	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
3448	return;	3448	return;
3449	}	3449	} else if (token.equals("invalidJavadoc")) { //$NON-NLS-1$
		3450	setSeverity(CompilerOptions.OPTION_ReportInvalidJavadoc, severity, isEnabling);
		3451	this.options.put(
		3452	CompilerOptions.OPTION_ReportInvalidJavadocTags,
		3453	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3454	this.options.put(
		3455	CompilerOptions.OPTION_ReportInvalidJavadocTagsDeprecatedRef,
		3456	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3457	this.options.put(
		3458	CompilerOptions.OPTION_ReportInvalidJavadocTagsNotVisibleRef,
		3459	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3460	if (isEnabling) {
		3461	this.options.put(
		3462	CompilerOptions.OPTION_DocCommentSupport,
		3463	CompilerOptions.ENABLED);
		3464	this.options.put(
		3465	CompilerOptions.OPTION_ReportInvalidJavadocTagsVisibility,
		3466	CompilerOptions.PRIVATE);
		3467	}
		3468	return;
		3469	} else if (token.equals("invalidJavadocTag")) { //$NON-NLS-1$
		3470	this.options.put(
		3471	CompilerOptions.OPTION_ReportInvalidJavadocTags,
		3472	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3473	return;
		3474	} else if (token.equals("invalidJavadocTagDep")) { //$NON-NLS-1$
		3475	this.options.put(
		3476	CompilerOptions.OPTION_ReportInvalidJavadocTagsDeprecatedRef,
		3477	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3478	return;
		3479	} else if (token.equals("invalidJavadocTagNotVisible")) { //$NON-NLS-1$
		3480	this.options.put(
		3481	CompilerOptions.OPTION_ReportInvalidJavadocTagsNotVisibleRef,
		3482	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3483	return;
		3484	} else if (token.startsWith("invalidJavadocTagVisibility")) { //$NON-NLS-1$
		3485	int start = token.indexOf('(');
		3486	int end = token.indexOf(')');
		3487	String visibility = null;
		3488	if (isEnabling && start >= 0 && end >= 0 && start < end){
		3489	visibility = token.substring(start+1, end).trim();
		3490	}
		3491	if (visibility != null && visibility.equals(CompilerOptions.PUBLIC)
		3492	\|\| visibility.equals(CompilerOptions.PRIVATE)
		3493	\|\| visibility.equals(CompilerOptions.PROTECTED)
		3494	\|\| visibility.equals(CompilerOptions.DEFAULT)) {
		3495	this.options.put(
		3496	CompilerOptions.OPTION_ReportInvalidJavadocTagsVisibility,
		3497	visibility);
		3498	return;
		3499	} else {
		3500	throw new IllegalArgumentException(this.bind("configure.invalidJavadocTagVisibility", token)); //$NON-NLS-1$
		3501	}
		3502	}
3450	break;	3503	break;
3451	case 'j' :	3504	case 'j' :
3452	if (token.equals("javadoc")) {//$NON-NLS-1$	3505	if (token.equals("javadoc")) {//$NON-NLS-1$
Lines 3466-3471 Link Here
3466	if (token.equals("maskedCatchBlock") \|\| token.equals("maskedCatchBlocks")/backward compatible/) { //$NON-NLS-1$ //$NON-NLS-2$	3519	if (token.equals("maskedCatchBlock") \|\| token.equals("maskedCatchBlocks")/backward compatible/) { //$NON-NLS-1$ //$NON-NLS-2$
3467	setSeverity(CompilerOptions.OPTION_ReportHiddenCatchBlock, severity, isEnabling);	3520	setSeverity(CompilerOptions.OPTION_ReportHiddenCatchBlock, severity, isEnabling);
3468	return;	3521	return;
		3522	} else if (token.equals("missingJavadocTags")) { //$NON-NLS-1$
		3523	setSeverity(CompilerOptions.OPTION_ReportMissingJavadocTags, severity, isEnabling);
		3524	this.options.put(
		3525	CompilerOptions.OPTION_ReportMissingJavadocTagsOverriding,
		3526	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3527	this.options.put(
		3528	CompilerOptions.OPTION_ReportMissingJavadocTagsMethodTypeParameters,
		3529	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3530	if (isEnabling) {
		3531	this.options.put(
		3532	CompilerOptions.OPTION_DocCommentSupport,
		3533	CompilerOptions.ENABLED);
		3534	this.options.put(
		3535	CompilerOptions.OPTION_ReportMissingJavadocTagsVisibility,
		3536	CompilerOptions.PRIVATE);
		3537	}
		3538	return;
		3539	} else if (token.equals("missingJavadocTagsOverriding")) { //$NON-NLS-1$
		3540	this.options.put(
		3541	CompilerOptions.OPTION_ReportMissingJavadocTagsOverriding,
		3542	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3543	return;
		3544	} else if (token.equals("missingJavadocTagsMethod")) { //$NON-NLS-1$
		3545	this.options.put(
		3546	CompilerOptions.OPTION_ReportMissingJavadocTagsMethodTypeParameters,
		3547	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3548	return;
		3549	} else if (token.startsWith("missingJavadocTagsVisibility")) { //$NON-NLS-1$
		3550	int start = token.indexOf('(');
		3551	int end = token.indexOf(')');
		3552	String visibility = null;
		3553	if (isEnabling && start >= 0 && end >= 0 && start < end){
		3554	visibility = token.substring(start+1, end).trim();
		3555	}
		3556	if (visibility != null && visibility.equals(CompilerOptions.PUBLIC)
		3557	\|\| visibility.equals(CompilerOptions.PRIVATE)
		3558	\|\| visibility.equals(CompilerOptions.PROTECTED)
		3559	\|\| visibility.equals(CompilerOptions.DEFAULT)) {
		3560	this.options.put(
		3561	CompilerOptions.OPTION_ReportMissingJavadocTagsVisibility,
		3562	visibility);
		3563	return;
		3564	} else {
		3565	throw new IllegalArgumentException(this.bind("configure.missingJavadocTagsVisibility", token)); //$NON-NLS-1$
		3566	}
		3567	} else if (token.equals("missingJavadocComments")) { //$NON-NLS-1$
		3568	setSeverity(CompilerOptions.OPTION_ReportMissingJavadocComments, severity, isEnabling);
		3569	this.options.put(
		3570	CompilerOptions.OPTION_ReportMissingJavadocCommentsOverriding,
		3571	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3572	if (isEnabling) {
		3573	this.options.put(
		3574	CompilerOptions.OPTION_DocCommentSupport,
		3575	CompilerOptions.ENABLED);
		3576	this.options.put(
		3577	CompilerOptions.OPTION_ReportMissingJavadocCommentsVisibility,
		3578	CompilerOptions.PRIVATE);
		3579	}
		3580	return;
		3581	} else if (token.equals("missingJavadocCommentsOverriding")) { //$NON-NLS-1$
		3582	setSeverity(CompilerOptions.OPTION_ReportMissingJavadocComments, severity, isEnabling);
		3583	this.options.put(
		3584	CompilerOptions.OPTION_ReportMissingJavadocCommentsOverriding,
		3585	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
3586	return;
3587	} else if (token.startsWith("missingJavadocCommentsVisibility")) { //$NON-NLS-1$
3588	int start = token.indexOf('(');
3589	int end = token.indexOf(')');
3590	String visibility = null;
3591	if (isEnabling && start >= 0 && end >= 0 && start < end){
3592	visibility = token.substring(start+1, end).trim();
3593	}
3594	if (visibility != null && visibility.equals(CompilerOptions.PUBLIC)
3595	\|\| visibility.equals(CompilerOptions.PRIVATE)
3596	\|\| visibility.equals(CompilerOptions.PROTECTED)
3597	\|\| visibility.equals(CompilerOptions.DEFAULT)) {
3598	this.options.put(
3599	CompilerOptions.OPTION_ReportMissingJavadocCommentsVisibility,
3600	visibility);
3601	return;
3602	} else {
3603	throw new IllegalArgumentException(this.bind("configure.missingJavadocCommentsVisibility", token)); //$NON-NLS-1$
3604	}
3469	}	3605	}
3470	break;	3606	break;
3471	case 'n' :	3607	case 'n' :
Lines 3666-3671 Link Here
3666	} else if (token.equals("unusedThrown")) { //$NON-NLS-1$	3802	} else if (token.equals("unusedThrown")) { //$NON-NLS-1$
3667	setSeverity(CompilerOptions.OPTION_ReportUnusedDeclaredThrownException, severity, isEnabling);	3803	setSeverity(CompilerOptions.OPTION_ReportUnusedDeclaredThrownException, severity, isEnabling);
3668	return;	3804	return;
		3805	} else if (token.equals("unusedThrownWhenOverriding")) { //$NON-NLS-1$
		3806	this.options.put(
		3807	CompilerOptions.OPTION_ReportUnusedDeclaredThrownExceptionWhenOverriding,
		3808	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3809	return;
		3810	} else if (token.equals("unusedThrownIncludeDocComment")) { //$NON-NLS-1$
		3811	this.options.put(
		3812	CompilerOptions.OPTION_ReportUnusedDeclaredThrownExceptionIncludeDocCommentReference,
		3813	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3814	return;
		3815	} else if (token.equals("unusedThrownExemptExceptionThrowable")) { //$NON-NLS-1$
		3816	this.options.put(
		3817	CompilerOptions.OPTION_ReportUnusedDeclaredThrownExceptionExemptExceptionAndThrowable,
		3818	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3819	return;
3669	} else if (token.equals("unqualifiedField") \|\| token.equals("unqualified-field-access")) { //$NON-NLS-1$ //$NON-NLS-2$	3820	} else if (token.equals("unqualifiedField") \|\| token.equals("unqualified-field-access")) { //$NON-NLS-1$ //$NON-NLS-2$
3670	setSeverity(CompilerOptions.OPTION_ReportUnqualifiedFieldAccess, severity, isEnabling);	3821	setSeverity(CompilerOptions.OPTION_ReportUnqualifiedFieldAccess, severity, isEnabling);
3671	return;	3822	return;
Lines 3679-3685 Link Here
3679	setSeverity(CompilerOptions.OPTION_ReportUnusedTypeArgumentsForMethodInvocation, severity, isEnabling);	3830	setSeverity(CompilerOptions.OPTION_ReportUnusedTypeArgumentsForMethodInvocation, severity, isEnabling);
3680	setSeverity(CompilerOptions.OPTION_ReportRedundantSpecificationOfTypeArguments, severity, isEnabling);	3831	setSeverity(CompilerOptions.OPTION_ReportRedundantSpecificationOfTypeArguments, severity, isEnabling);
3681	return;	3832	return;
3682	} else if (token.equals("unusedTypeArgs")) { //$NON-NLS-1$	3833	} else if (token.equals("unusedParam")) { //$NON-NLS-1$
		3834	setSeverity(CompilerOptions.OPTION_ReportUnusedParameter, severity, isEnabling);
		3835	return;
		3836	} else if (token.equals("unusedParamIncludeDoc")) { //$NON-NLS-1$
		3837	this.options.put(
		3838	CompilerOptions.OPTION_ReportUnusedParameterIncludeDocCommentReference,
		3839	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3840	return;
		3841	} else if (token.equals("unusedParamOverriding")) { //$NON-NLS-1$
		3842	this.options.put(
		3843	CompilerOptions.OPTION_ReportUnusedParameterWhenOverridingConcrete,
		3844	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3845	return;
		3846	} else if (token.equals("unusedParamImplementing")) { //$NON-NLS-1$
		3847	this.options.put(
		3848	CompilerOptions.OPTION_ReportUnusedParameterWhenImplementingAbstract,
		3849	isEnabling ? CompilerOptions.ENABLED : CompilerOptions.DISABLED);
		3850	return;
		3851	} else if (token.equals("unusedTypeArgs")) { //$NON-NLS-1$
3683	setSeverity(CompilerOptions.OPTION_ReportUnusedTypeArgumentsForMethodInvocation, severity, isEnabling);	3852	setSeverity(CompilerOptions.OPTION_ReportUnusedTypeArgumentsForMethodInvocation, severity, isEnabling);
3684	setSeverity(CompilerOptions.OPTION_ReportRedundantSpecificationOfTypeArguments, severity, isEnabling);	3853	setSeverity(CompilerOptions.OPTION_ReportRedundantSpecificationOfTypeArguments, severity, isEnabling);
3685	return;	3854	return;