Attachment 215417 Details for Bug 374121 – Updated patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Updated patch

374121.patch (text/plain), 2.07 KB, created by Brian de Alwis

on 2012-05-10 13:03:58 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brian de Alwis

Created: 2012-05-10 13:03:58 EDT

Size: 2.07 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java
>index 107c6ab..0297ef8 100644
>--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java	
>+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java	
>@@ -1687,6 +1687,19 @@ UIEvents.Context.TOPIC_CONTEXT,
> 					}
> 				});
> 		
>+		// watch for windows' widget being set, once they've been set, we
>+		// need to create a WorkbenchWindow
>+		eventBroker.subscribe(UIEvents.UIElement.TOPIC_WIDGET, new EventHandler() {
>+			public void handleEvent(org.osgi.service.event.Event event) {
>+				Object element = event.getProperty(UIEvents.EventTags.ELEMENT);
>+				if (element instanceof MWindow && UIEvents.isSET(event)
>+						&& event.getProperty(UIEvents.EventTags.NEW_VALUE) instanceof Shell) {
>+					MWindow window = (MWindow) element;
>+					createWorkbenchWindow(getDefaultPageInput(), null, window, false);
>+				}
>+			}
>+		});
>+
> 		boolean found = false;
> 		List<MPartDescriptor> currentDescriptors = application.getDescriptors();
> 		for (MPartDescriptor desc : currentDescriptors) {
>diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindowConfigurer.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindowConfigurer.java
>index 5949488..0475942 100644
>--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindowConfigurer.java	
>+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindowConfigurer.java	
>@@ -311,6 +311,8 @@ public final class WorkbenchWindowConfigurer implements
>             throw new IllegalArgumentException();
>         }
>         windowTitle = title;
>+	// FIXME: should be TextProcessor.process'd?
>+        window.getModel().setLabel(title);
>         Shell shell = window.getShell();
>         if (shell != null && !shell.isDisposed()) {
>             shell.setText(TextProcessor.process(title, WorkbenchWindow.TEXT_DELIMITERS));

Actions: View | Diff

Attachments on bug 374121: 212600 | 212601 | 212602 | 214925 | 215417 | 215474