Attachment 214721 Details for Bug 361926 – Fix for the regression

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix for the regression

clipboard.txt (text/plain), 2.39 KB, created by Malgorzata Janczarska

on 2012-04-27 12:24:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Malgorzata Janczarska

Created: 2012-04-27 12:24:08 EDT

Size: 2.39 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.team.cvs.ui
>diff --git src/org/eclipse/team/internal/ccvs/ui/repo/RepositoryRoot.java src/org/eclipse/team/internal/ccvs/ui/repo/RepositoryRoot.java
>index 7b45f71..c977ff8 100644
>--- src/org/eclipse/team/internal/ccvs/ui/repo/RepositoryRoot.java
>+++ src/org/eclipse/team/internal/ccvs/ui/repo/RepositoryRoot.java
>@@ -683,7 +683,7 @@
> 	 * @return CVSTag[]
> 	 */
> 	public CVSTag[] getAllKnownTags(String remotePath) {
>-		Set tags = new HashSet();
>+		Set tags = new HashSet(dateTags);
> 		addAllKnownTagsForParents(getKnownParentTagCacheEntryFor(remotePath),
> 				tags);
> 		TagCacheEntry entry = getTagCacheEntryFor(remotePath, false);
>@@ -694,7 +694,7 @@
> 	}
> 
> 	public CVSTag[] getAllKnownTags() {
>-		Set tags = new HashSet();
>+		Set tags = new HashSet(dateTags);
> 		addAllKnownTagsForChildren(rootTagCacheEntry, tags);
> 		return (CVSTag[]) tags.toArray(new CVSTag[tags.size()]);
> 	}
>#P org.eclipse.team.tests.cvs.core
>diff --git src/org/eclipse/team/tests/ccvs/core/provider/RepositoryRootTest.java src/org/eclipse/team/tests/ccvs/core/provider/RepositoryRootTest.java
>index 98c4838..6964dfc 100644
>--- src/org/eclipse/team/tests/ccvs/core/provider/RepositoryRootTest.java
>+++ src/org/eclipse/team/tests/ccvs/core/provider/RepositoryRootTest.java
>@@ -11,6 +11,7 @@
> package org.eclipse.team.tests.ccvs.core.provider;
> 
> import java.util.Arrays;
>+import java.util.Date;
> import java.util.List;
> 
> import junit.framework.Test;
>@@ -394,4 +395,24 @@
> 		assertEquals(0, knownTags.length);
> 	}
> 
>+	public void testDateTags() throws CoreException {
>+		CVSTag dateTag = new CVSTag(new Date());
>+		repositoryManager.addDateTag(getRepository(), dateTag);
>+		// verify if date tags are returned by repository manager
>+		CVSTag[] dateTags = repositoryManager.getDateTags(getRepository());
>+		assertEquals(1, dateTags.length);
>+		assertEquals(dateTag, dateTags[0]);
>+		dateTags = repositoryManager.getKnownTags(getRepository(), CVSTag.DATE);
>+		assertEquals(1, dateTags.length);
>+		assertEquals(dateTag, dateTags[0]);
>+		// verify if date tags are returned in list of known tags for every
>+		// project
>+		IProject project = createProject("Project_1", (String) null);
>+		CVSTag[] allTags = repositoryManager.getKnownTags(CVSWorkspaceRoot
>+				.getCVSFolderFor(project));
>+		assertEquals(1, allTags.length);
>+		assertEquals(dateTag, allTags[0]);
>+
>+	}
>+
> }

Actions: View | Diff

Attachments on bug 361926: 206585 | 206662 | 212811 | 213100 | 214721