Attachment 214365 Details for Bug 376724 – Proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix

Fix-for-bug-376724.patch (text/plain), 1.54 KB, created by Jay Arthanareeswaran

on 2012-04-23 03:02:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jay Arthanareeswaran

Created: 2012-04-23 03:02:46 EDT

Size: 1.54 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
>index 9ad73c8..45b097d 100644
>--- a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
>+++ b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
>@@ -51,13 +51,17 @@
> 	private Set pendingFolders; // subset of keys of 'folders', for which linked folders haven't been created yet.
> 	private int counter = 0;
> 	/* Singleton instance */
>-	private static ExternalFoldersManager MANAGER = new ExternalFoldersManager();
>+	private static ExternalFoldersManager MANAGER;
> 
> 	private ExternalFoldersManager() {
> 		// Prevent instantiation
>+		getFolders();
> 	}
> 	
>-	public static ExternalFoldersManager getExternalFoldersManager() {
>+	public static synchronized ExternalFoldersManager getExternalFoldersManager() {
>+		if (MANAGER == null) {
>+			 MANAGER = new ExternalFoldersManager();
>+		}
> 		return MANAGER;
> 	}
> 	
>@@ -123,8 +127,10 @@
> 			result = externalFoldersProject.getFolder(LINKED_FOLDER_NAME + this.counter++);
> 		} while (result.exists());
> 		if (scheduleForCreation) {
>-			if (this.pendingFolders == null)
>-				this.pendingFolders = Collections.synchronizedSet(new HashSet());
>+			synchronized(this) {
>+				if (this.pendingFolders == null)
>+					this.pendingFolders = Collections.synchronizedSet(new HashSet());
>+			}
> 			this.pendingFolders.add(externalFolderPath);
> 		}
> 		knownFolders.put(externalFolderPath, result);

Actions: View | Diff

Attachments on bug 376724: 214365 | 214487