Attachment 213980 Details for Bug 355763 – Can it be so easy?

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Can it be so easy?

eclipse.platform.ui.patch (text/plain), 3.69 KB, created by Thomas Schindl

on 2012-04-13 10:55:23 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Schindl

Created: 2012-04-13 10:55:23 EDT

Size: 3.69 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/cleanupaddon/CleanupAddon.java b/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/cleanupaddon/CleanupAddon.java
>index 3dff107..7999daf 100644
>--- a/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/cleanupaddon/CleanupAddon.java
>+++ b/bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/cleanupaddon/CleanupAddon.java
>@@ -28,6 +28,7 @@
> import org.eclipse.e4.ui.model.application.ui.basic.MWindow;
> import org.eclipse.e4.ui.model.application.ui.menu.MMenuElement;
> import org.eclipse.e4.ui.model.application.ui.menu.MToolBar;
>+import org.eclipse.e4.ui.workbench.IPresentationEngine;
> import org.eclipse.e4.ui.workbench.UIEvents;
> import org.eclipse.e4.ui.workbench.modeling.EModelService;
> import org.eclipse.e4.ui.workbench.renderers.swt.SashLayout;
>@@ -62,7 +63,8 @@
> 				// Determine the elements that should *not* ever be auto-destroyed
> 				if (container instanceof MApplication || container instanceof MPerspectiveStack
> 						|| container instanceof MMenuElement || container instanceof MTrimBar
>-						|| container instanceof MToolBar || container instanceof MArea) {
>+						|| container instanceof MToolBar || container instanceof MArea
>+						|| container.getTags().contains(IPresentationEngine.NO_CLOSE)) {
> 					return;
> 				}
> 
>@@ -262,6 +264,11 @@
> 				if (!container.isToBeRendered())
> 					container.setToBeRendered(true);
> 			} else {
>+				// Never hide the container marked as no_close
>+				if (container.getTags().contains(IPresentationEngine.NO_CLOSE)) {
>+					return;
>+				}
>+
> 				int visCount = modelService.countRenderableChildren(container);
> 
> 				// Remove stacks with no visible children from the display (but not the
>diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java
>index 3eae901..a64633b 100644
>--- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java
>+++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java
>@@ -34,8 +34,9 @@
> 	public static final String NO_TITLE = "NoTitle"; //$NON-NLS-1$
> 
> 	/**
>-	 * When applied as a tag to an MPlaceholder inhibits the display of the close affordance. This
>-	 * allows a part to be closeable in one perspective but not in a different one.
>+	 * Applying this tag to a container will ensure that the container remains visible in the UI
>+	 * even if it has no visible content. Applying the tag to a UI 'leaf' element (MPart /
>+	 * MPlaceholder) will cause the renderer to not provide a 'close' affordance.
> 	 * 
> 	 * <b>NOTE:</b> If you are not using perspectives then use the MPart's 'isCloseable' attribute
> 	 * to control the affordance.
>@@ -69,10 +70,10 @@
> 	public static String MINIMIZED_BY_ZOOM = "MinimizedByZoom"; //$NON-NLS-1$
> 
> 	/**
>-	 * This key should be used to add an optional String to an element that is a
>-	 * URI to the elements disabled icon.  This is used, for example, by Toolbar Items
>-	 * which, in Eclipse SDK, provide a unique icon for disabled tool items that look better
>-	 * than the OS default graying on the default icon.
>+	 * This key should be used to add an optional String to an element that is a URI to the elements
>+	 * disabled icon. This is used, for example, by Toolbar Items which, in Eclipse SDK, provide a
>+	 * unique icon for disabled tool items that look better than the OS default graying on the
>+	 * default icon.
> 	 * 
> 	 * There is a strong argument to be made that this disabledIconURI actually be part of the model
> 	 */

Actions: View | Diff

Attachments on bug 355763: 213980 | 213981