Attachment 213895 Details for Bug 364026 – Revised

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Revised

bug364026-revisedPatch.txt (text/plain), 6.19 KB, created by Keith Chong

on 2012-04-12 09:21:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Chong

Created: 2012-04-12 09:21:57 EDT

Size: 6.19 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jst.ws.axis.consumption.ui
>Index: src/org/eclipse/jst/ws/internal/axis/consumption/ui/task/CopyAxisJarCommand.java
>===================================================================
>RCS file: /cvsroot/webtools/webservices/plugins/org.eclipse.jst.ws.axis.consumption.ui/src/org/eclipse/jst/ws/internal/axis/consumption/ui/task/CopyAxisJarCommand.java,v
>retrieving revision 1.36
>diff -u -r1.36 CopyAxisJarCommand.java
>--- src/org/eclipse/jst/ws/internal/axis/consumption/ui/task/CopyAxisJarCommand.java	20 Apr 2010 15:43:27 -0000	1.36
>+++ src/org/eclipse/jst/ws/internal/axis/consumption/ui/task/CopyAxisJarCommand.java	12 Apr 2012 13:15:56 -0000
>@@ -60,6 +60,7 @@
> import org.eclipse.wst.common.environment.IEnvironment;
> import org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation;
> import org.eclipse.wst.ws.internal.common.BundleUtils;
>+import org.osgi.framework.Version;
> 
> 
> public class CopyAxisJarCommand extends AbstractDataModelOperation {
>@@ -71,6 +72,8 @@
> 	public static String JAVAX_XML_RPC_PLUGIN_ID = "javax.xml.rpc"; //$NON-NLS-1$
> 	public static String JAVAX_XML_RPC_JAR = "jaxrpc.jar"; //$NON-NLS-1$
> 	public static String JAVAX_XML_SOAP_PLUGIN_ID = "javax.xml.soap"; //$NON-NLS-1$
>+	public static Version JAVAX_XML_SOAP_PLUGIN_VERSION = Version.parseVersion("1.2.0");
>+	private static Version JAVAX_XML_SOAP_PLUGIN_UPPER_VERSION = Version.parseVersion("1.3.0");
> 	public static String JAVAX_XML_SOAP_JAR = "saaj.jar"; //$NON-NLS-1$
> 	public static String JAVAX_WSDL_PLUGIN_ID = "javax.wsdl"; //$NON-NLS-1$
> 	public static String JAVAX_WSDL_JAR = "wsdl4j.jar"; //$NON-NLS-1$
>@@ -150,19 +153,19 @@
> 		deleteObsoleteJars(webModulePath);
> 
> 
>-		copyIFile(AXIS_RUNTIME_PLUGIN_ID, "lib/" + AXIS_JAR, webModulePath, "WEB-INF/lib/" + AXIS_JAR, status, env, monitor);
>+		copyIFile(AXIS_RUNTIME_PLUGIN_ID, null, null, "lib/" + AXIS_JAR, webModulePath, "WEB-INF/lib/" + AXIS_JAR, status, env, monitor);
> 		if (status.getSeverity() == Status.ERROR) {
> 			return;
> 		}
>-		copyIFile(COMMON_DISCOVERY_PLUGIN_ID, "lib/" + COMMON_DISCOVERY_JAR, webModulePath, "WEB-INF/lib/" + COMMON_DISCOVERY_JAR, status, env, monitor);
>+		copyIFile(COMMON_DISCOVERY_PLUGIN_ID, null, null, "lib/" + COMMON_DISCOVERY_JAR, webModulePath, "WEB-INF/lib/" + COMMON_DISCOVERY_JAR, status, env, monitor);
> 		if (status.getSeverity() == Status.ERROR) {
> 			return;
> 		}
>-		copyIFile(JAVAX_XML_RPC_PLUGIN_ID, "lib/" + JAVAX_XML_RPC_JAR, webModulePath, "WEB-INF/lib/" + JAVAX_XML_RPC_JAR, status, env, monitor);
>+		copyIFile(JAVAX_XML_RPC_PLUGIN_ID, null, null, "lib/" + JAVAX_XML_RPC_JAR, webModulePath, "WEB-INF/lib/" + JAVAX_XML_RPC_JAR, status, env, monitor);
> 		if (status.getSeverity() == Status.ERROR) {
> 			return;
> 		}
>-		copyIFile(JAVAX_XML_SOAP_PLUGIN_ID, "lib/" + JAVAX_XML_SOAP_JAR, webModulePath, "WEB-INF/lib/" + JAVAX_XML_SOAP_JAR, status, env, monitor);
>+		copyIFile(JAVAX_XML_SOAP_PLUGIN_ID, JAVAX_XML_SOAP_PLUGIN_VERSION, JAVAX_XML_SOAP_PLUGIN_UPPER_VERSION, "lib/" + JAVAX_XML_SOAP_JAR, webModulePath, "WEB-INF/lib/" + JAVAX_XML_SOAP_JAR, status, env, monitor);
> 		if (status.getSeverity() == Status.ERROR) {
> 			return;
> 		}
>@@ -181,7 +184,7 @@
> 	/**
> 	 * 
> 	 */
>-	private void copyIFile(String pluginId, String source, IPath targetPath, String targetFile, IStatus status, IEnvironment env, IProgressMonitor monitor) {
>+	private void copyIFile(String pluginId, Version pluginVersion, Version upperVersion, String source, IPath targetPath, String targetFile, IStatus status, IEnvironment env, IProgressMonitor monitor) {
> 		IPath target = targetPath.append(new Path(targetFile));
> 		ProgressUtils.report(monitor, ConsumptionMessages.PROGRESS_INFO_COPYING_FILE);
> 
>@@ -190,7 +193,15 @@
> 			context.setOverwriteFilesEnabled(true);
> 			context.setCreateFoldersEnabled(true);
> 			context.setCheckoutFilesEnabled(true);
>-			URL sourceURL = BundleUtils.getURLFromBundle(pluginId, source);
>+
>+			URL sourceURL = null;
>+			if (pluginVersion != null) {
>+				sourceURL = BundleUtils.getURLFromBundle(pluginId, pluginVersion, upperVersion, source);
>+			}
>+			else {
>+				sourceURL = BundleUtils.getURLFromBundle(pluginId, source);
>+			}
>+
> 			IFile resource = ResourceUtils.getWorkspaceRoot().getFile(target);
> 			if (!resource.exists()) {
> 				IFile file = FileResourceUtils.createFile(context, target, sourceURL.openStream(), monitor, env.getStatusHandler());
>#P org.eclipse.wst.ws
>Index: src/org/eclipse/wst/ws/internal/common/BundleUtils.java
>===================================================================
>RCS file: /cvsroot/webtools/webservices/plugins/org.eclipse.wst.ws/src/org/eclipse/wst/ws/internal/common/BundleUtils.java,v
>retrieving revision 1.4
>diff -u -r1.4 BundleUtils.java
>--- src/org/eclipse/wst/ws/internal/common/BundleUtils.java	26 Mar 2008 21:23:14 -0000	1.4
>+++ src/org/eclipse/wst/ws/internal/common/BundleUtils.java	12 Apr 2012 13:15:56 -0000
>@@ -30,13 +30,35 @@
> {
> 	static public URL getURLFromBundle( String bundleId, String path ) throws MalformedURLException
> 	{
>-		Bundle      bundle     = Platform.getBundle( bundleId );
>+		Bundle      bundle     = Platform.getBundle(bundleId);
> 		URL         installURL = bundle.getEntry("/");
> 		URL         fileURL    = new URL(installURL, path );
> 
> 		return fileURL;
> 	}
> 
>+	static public URL getURLFromBundle( String bundleId, Version bundleVersion, Version upperVersion, String path ) throws MalformedURLException
>+	{
>+		Bundle      bundle     = getBundleWithinVersionRange(bundleId, bundleVersion, upperVersion);
>+		URL         installURL = bundle.getEntry("/");
>+		URL         fileURL    = new URL(installURL, path );
>+
>+		return fileURL;
>+	}
>+
>+	private static Bundle getBundleWithinVersionRange(String bundleId,
>+			Version bundleVersion, Version upperVersion) {
>+		Bundle[] bundles = Platform.getBundles(bundleId, bundleVersion.toString());
>+		for(Bundle bundle : bundles) {
>+			Version aVersion = bundle.getVersion();
>+			if (aVersion.compareTo(bundleVersion) >= 0 && aVersion.compareTo(upperVersion) < 0) {
>+				return bundle;
>+			}
>+		}
>+		
>+		return null;
>+	}
>+
> 	/**
> 	 * @param bundleId
> 	 * @return Returns the path for the Jarred plugin.  Returns null if path not found.

Actions: View | Diff

Attachments on bug 364026: 212906 | 213895 | 214202