Attachment 213123 Details for Bug 375194 – Patch proposal which works for me

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch proposal which works for me

patch.txt (text/plain), 1.27 KB, created by Nobody - feel free to take it

on 2012-03-23 15:11:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nobody - feel free to take it

Created: 2012-03-23 15:11:51 EDT

Size: 1.27 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java
>index 341d0ad..037cd35 100644
>--- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java
>+++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java
>@@ -560,12 +560,14 @@
> 		// find the correct place to start the insertion
> 		MUIElement insertRoot = relTo.getParent();
> 		while (insertRoot != null && !(insertRoot instanceof MWindow)
>-				&& !(insertRoot instanceof MPartSashContainer)) {
>+				&& !(insertRoot instanceof MPartSashContainer)
>+				&& !(insertRoot instanceof MPerspective)) {
> 			relTo = (MPartSashContainerElement) insertRoot;
> 			insertRoot = insertRoot.getParent();
> 		}
> 
>-		if (insertRoot instanceof MWindow || insertRoot instanceof MArea) {
>+		if (insertRoot instanceof MWindow || insertRoot instanceof MArea
>+				|| insertRoot instanceof MPerspective) {
> 			// OK, we're certainly going to need a new sash
> 			MPartSashContainer newSash = BasicFactoryImpl.eINSTANCE.createPartSashContainer();
> 			newSash.setHorizontal(where == LEFT_OF || where == RIGHT_OF);

Actions: View | Diff

Attachments on bug 375194: 213122 | 213123