Attachment #213123 for bug #375194

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

View | Details | Raw Unified | Return to bug 375194
Collapse All | Expand All




		// find the correct place to start the insertion
		MUIElement insertRoot = relTo.getParent();
		while (insertRoot != null && !(insertRoot instanceof MWindow)
				&& !(insertRoot instanceof MPartSashContainer)
				&& !(insertRoot instanceof MPerspective)) {
			relTo = (MPartSashContainerElement) insertRoot;
			insertRoot = insertRoot.getParent();
		}

		if (insertRoot instanceof MWindow || insertRoot instanceof MArea
				|| insertRoot instanceof MPerspective) {
			// OK, we're certainly going to need a new sash
			MPartSashContainer newSash = BasicFactoryImpl.eINSTANCE.createPartSashContainer();
			newSash.setHorizontal(where == LEFT_OF || where == RIGHT_OF);

Return to bug 375194

Lines 560-571 Link Here

(-)a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java (-2 / +4 lines)
560	// find the correct place to start the insertion	560	// find the correct place to start the insertion
561	MUIElement insertRoot = relTo.getParent();	561	MUIElement insertRoot = relTo.getParent();
562	while (insertRoot != null && !(insertRoot instanceof MWindow)	562	while (insertRoot != null && !(insertRoot instanceof MWindow)
563	&& !(insertRoot instanceof MPartSashContainer)) {	563	&& !(insertRoot instanceof MPartSashContainer)
		564	&& !(insertRoot instanceof MPerspective)) {
564	relTo = (MPartSashContainerElement) insertRoot;	565	relTo = (MPartSashContainerElement) insertRoot;
565	insertRoot = insertRoot.getParent();	566	insertRoot = insertRoot.getParent();
566	}	567	}
567		568
568	if (insertRoot instanceof MWindow \|\| insertRoot instanceof MArea) {	569	if (insertRoot instanceof MWindow \|\| insertRoot instanceof MArea
		570	\|\| insertRoot instanceof MPerspective) {
569	// OK, we're certainly going to need a new sash	571	// OK, we're certainly going to need a new sash
570	MPartSashContainer newSash = BasicFactoryImpl.eINSTANCE.createPartSashContainer();	572	MPartSashContainer newSash = BasicFactoryImpl.eINSTANCE.createPartSashContainer();
571	newSash.setHorizontal(where == LEFT_OF \|\| where == RIGHT_OF);	573	newSash.setHorizontal(where == LEFT_OF \|\| where == RIGHT_OF);