Attachment 212604 Details for Bug 374096 – Patch for Bug 374096 and Comment#4

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for Bug 374096 and Comment#4

Bug 374096.patch (text/plain), 3.62 KB, created by Sascha Becher

on 2012-03-13 17:47:55 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sascha Becher

Created: 2012-03-13 17:47:55 EDT

Size: 3.62 KB

patch

obsolete

>From 54633ca90045820111cdd0354e8bbd31ea7936fe Tue, 13 Mar 2012 22:34:14 +0100
>From: zour <s.becher@qualitype.de>
>Date: Tue, 13 Mar 2012 22:32:59 +0100
>Subject: [PATCH] Bug 374096 - Cheese in the manifest editor
>
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java
>index c41b1ef..c5705f0 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java
>@@ -243,9 +243,8 @@
> 		TreePart treePart = getTreePart();
> 		createViewerPartControl(container, SWT.MULTI, 2, toolkit);
> 		// fix layout to place search button right to the filter text 
>-		Control searchButton = treePart.getButton(BUTTON_SEARCH);
>+		final Control searchButton = treePart.getButton(BUTTON_SEARCH);
> 		((GridLayout) searchButton.getParent().getLayout()).marginHeight = 2;
>-		searchButton.setLayoutData(GridDataFactory.swtDefaults().align(SWT.BEGINNING, SWT.BEGINNING).grab(false, false).hint(SWT.DEFAULT, 19).create());
> 		searchButton.setToolTipText(PDEUIMessages.ExtensionsPage_searchWithExtensionsFilter);
> 		Control addButton = treePart.getButton(BUTTON_ADD);
> 		((GridData) addButton.getLayoutData()).verticalIndent = 16;
>@@ -273,6 +272,14 @@
> 				}
> 			});
> 		}
>+		// Layout fixed for Bug 374096
>+		Display.getCurrent().asyncExec(new Runnable() {
>+			public void run() {
>+				int height = fFilteredTree.getFilterControl().getParent().getBounds().height;
>+				searchButton.setLayoutData(GridDataFactory.defaultsFor(searchButton).align(SWT.FILL, SWT.BEGINNING).grab(false, false).hint(SWT.DEFAULT, height).create());
>+				searchButton.getParent().layout();
>+			}
>+		});
> 	}
> 
> 	/**
>@@ -317,12 +324,14 @@
> 				}
> 			}
> 		};
>+		fSortAction.setDisabledImageDescriptor(PDEPluginImages.DESC_ALPHAB_SORT_CO_DISABLED);
> 		toolBarManager.add(fSortAction);
> 		// Add expand selected leafs action to the toolbar
> 		fExpandAction = new ToggleExpandStateAction(fFilteredTree, fExtensionTree);
> 		toolBarManager.add(fExpandAction);
> 		// Add collapse action to the tool bar
> 		fCollapseAction = new CollapseAction(fExtensionTree, PDEUIMessages.ExtensionsPage_collapseAll);
>+		fCollapseAction.setDisabledImageDescriptor(PDEPluginImages.DESC_COLLAPSE_ALL_DISABLED);
> 		toolBarManager.add(fCollapseAction);
> 
> 		toolBarManager.update(true);
>@@ -1327,6 +1336,10 @@
> 			getTreePart().setButtonEnabled(BUTTON_SEARCH, searchEnabled);
> 			fSearchToolbarAction.setEnabled(filterRelatedEnabled);
> 		}
>+		// see Bug 374096
>+		if (getSection() != null && getSection().getTextClient() != null) {
>+			getSection().getTextClient().redraw();
>+		}
> 
> 		if (getPage().getModel().isEditable() == false)
> 			return;
>diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>index 1dac715..2347399 100644
>--- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>+++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
>@@ -1542,7 +1542,7 @@
> ExtensionsPage_tabName=Extensions
> ExtensionsPage_sortAlpha=Sort the Extensions alphabetically
> ExtensionsPage_toggleExpandState=Toggle Expand State
>-ExtensionsPage_searchWithExtensionsFilter=Search with current filter 
>+ExtensionsPage_searchWithExtensionsFilter=Search platform plugins with current filter 
> ExtensionDetails_title=Extension Details
> ExtensionDetails_desc=Set the properties of the selected extension. Required fields are denoted by "*".
> ExtensionDetails_id=ID

Actions: View | Diff

Attachments on bug 374096: 212567 | 212577 | 212604