Attachment 211867 Details for Bug 372960 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-372960.patch (text/plain), 2.38 KB, created by Ivan Furnadjiev

on 2012-03-01 06:24:09 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2012-03-01 06:24:09 EST

Size: 2.38 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/rwt/internal/lifecycle/PhaseListenerManager.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/rwt/internal/lifecycle/PhaseListenerManager.java,v
>retrieving revision 1.3
>diff -u -r1.3 PhaseListenerManager.java
>--- src/org/eclipse/rwt/internal/lifecycle/PhaseListenerManager.java	11 Jul 2011 20:25:31 -0000	1.3
>+++ src/org/eclipse/rwt/internal/lifecycle/PhaseListenerManager.java	1 Mar 2012 11:13:04 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2011 EclipseSource and others.
>+ * Copyright (c) 2011, 2012 EclipseSource and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -11,7 +11,7 @@
> package org.eclipse.rwt.internal.lifecycle;
> 
> import java.text.MessageFormat;
>-import java.util.HashSet;
>+import java.util.LinkedHashSet;
> import java.util.Set;
> 
> import org.eclipse.rwt.internal.service.ServletLog;
>@@ -24,20 +24,20 @@
>   private final ILifeCycle eventSource;
>   private final Object lock;
>   private final Set<PhaseListener> phaseListeners;
>-  
>+
>   PhaseListenerManager( ILifeCycle eventSource ) {
>     this.eventSource = eventSource;
>     this.lock = new Object();
>-    this.phaseListeners = new HashSet<PhaseListener>();
>+    this.phaseListeners = new LinkedHashSet<PhaseListener>();
>   }
>-  
>+
>   void addPhaseListener( PhaseListener phaseListener ) {
>     ParamCheck.notNull( phaseListener, "phaseListener" );
>     synchronized( lock ) {
>       phaseListeners.add( phaseListener );
>     }
>   }
>-  
>+
>   void addPhaseListeners( PhaseListener[] phaseListeners ) {
>     ParamCheck.notNull( phaseListeners, "phaseListeners" );
>     for( int i = 0; i < phaseListeners.length; i++ ) {
>@@ -59,7 +59,7 @@
>       return result;
>     }
>   }
>-  
>+
>   void notifyBeforePhase( PhaseId phase ) {
>     PhaseListener[] phaseListeners = getPhaseListeners();
>     PhaseEvent event = new PhaseEvent( eventSource, phase );
>@@ -89,7 +89,7 @@
>       }
>     }
>   }
>-  
>+
>   private static boolean mustNotify( PhaseId phase, PhaseId listenerPhase ) {
>     return listenerPhase == PhaseId.ANY || listenerPhase == phase;
>   }

Actions: View | Diff

Attachments on bug 372960: 211867 | 211881 | 211919