Attachment 211087 Details for Bug 268135 – patch v0.1

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch v0.1

patch268135.txt (text/plain), 1.92 KB, created by Marek Chodorowski

on 2012-02-16 02:22:02 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marek Chodorowski

Created: 2012-02-16 02:22:02 EST

Size: 1.92 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/FocusCellOwnerDrawHighlighter.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/FocusCellOwnerDrawHighlighter.java
>index 53dc7ca..e7ee99d 100644
>--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/FocusCellOwnerDrawHighlighter.java
>+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/FocusCellOwnerDrawHighlighter.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2007, 2008 IBM Corporation and others.
>+ * Copyright (c) 2007, 2012 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -83,16 +83,6 @@
> 		}
> 	}
> 
>-	private void removeSelectionInformation(Event event, ViewerCell cell) {
>-		GC gc = event.gc;
>-		gc.setBackground(cell.getViewerRow().getBackground(
>-				cell.getColumnIndex()));
>-		gc.setForeground(cell.getViewerRow().getForeground(
>-				cell.getColumnIndex()));
>-		gc.fillRectangle(cell.getBounds());
>-		event.detail &= ~SWT.SELECTED;
>-	}
>-
> 	private void hookListener(final ColumnViewer viewer) {
> 
> 		Listener listener = new Listener() {
>@@ -108,11 +98,9 @@
> 
> 					ViewerCell cell = row.getCell(event.index);
> 
>-					if (focusCell == null || !cell.equals(focusCell)) {
>-						removeSelectionInformation(event, cell);
>-					} else {
>-						markFocusedCell(event, cell);
>-					}
>+					if (focusCell != null && cell.equals(focusCell)) {
>+                        markFocusedCell(event, cell);
>+                    }
> 				}
> 			}
> 
>@@ -129,7 +117,7 @@
> 	 * @return the color or <code>null</code> to use the default
> 	 */
> 	protected Color getSelectedCellBackgroundColor(ViewerCell cell) {
>-		return null;
>+		return cell.getItem().getDisplay().getSystemColor(SWT.COLOR_LIST_SELECTION);
> 	}
> 
> 	/**

Actions: View | Diff

Attachments on bug 268135: 128469 | 128470 | 197612 | 211087