Attachment 210031 Details for Bug 320182 – Adopted patch (attachment 205970) for 14_Maintenance branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Adopted patch (attachment 205970) for 14_Maintenance branch

Bug-320182-v1.4.patch (text/plain), 1.94 KB, created by Ivan Furnadjiev

on 2012-01-25 02:30:27 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2012-01-25 02:30:27 EST

Size: 1.94 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.ui.workbench
>Index: Eclipse UI/org/eclipse/rap/ui/internal/progress/JobManagerAdapter.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.ui/org.eclipse.rap.ui.workbench/Eclipse UI/org/eclipse/rap/ui/internal/progress/JobManagerAdapter.java,v
>retrieving revision 1.9
>diff -u -r1.9 JobManagerAdapter.java
>--- Eclipse UI/org/eclipse/rap/ui/internal/progress/JobManagerAdapter.java	20 Apr 2011 12:32:51 -0000	1.9
>+++ Eclipse UI/org/eclipse/rap/ui/internal/progress/JobManagerAdapter.java	25 Jan 2012 07:28:06 -0000
>@@ -21,7 +21,6 @@
> import org.eclipse.core.runtime.jobs.*;
> import org.eclipse.rwt.RWT;
> import org.eclipse.rwt.internal.lifecycle.LifeCycleUtil;
>-import org.eclipse.rwt.internal.lifecycle.RWTLifeCycle;
> import org.eclipse.rwt.internal.lifecycle.UICallBackServiceHandler;
> import org.eclipse.rwt.internal.service.ContextProvider;
> import org.eclipse.rwt.lifecycle.UICallBack;
>@@ -117,15 +116,6 @@
>       try {
>         manager[ 0 ] = findProgressManager( event.getJob() );
>         display = ( Display )jobs.get( event.getJob() );
>-        if( display != null && !display.isDisposed() ) {
>-          display.asyncExec( new Runnable() {
>-            public void run() {
>-              Job job = event.getJob();
>-              String id = String.valueOf( job.hashCode() );
>-              UICallBackServiceHandler.deactivateUICallBacksFor( id );
>-            }
>-          } );
>-        }
>       } finally {
>         jobs.remove( event.getJob() );
>       }
>@@ -133,6 +123,8 @@
>     if( display != null && !display.isDisposed() ) {
>       display.asyncExec( new Runnable() {
>         public void run() {
>+          String id = String.valueOf( event.getJob().hashCode() );
>+          UICallBackServiceHandler.deactivateUICallBacksFor( id );
>           manager[ 0 ].changeListener.done( event );
>         }
>       } );

Flags:

rsternberg: review+

Actions: View | Diff

Attachments on bug 320182: 182346 | 205970 | 210031