Attachment 209673 Details for Bug 368950 – SelectionDispatchAction.dispatchSelectionChanged() in non UI thread

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] SelectionDispatchAction.dispatchSelectionChanged() in non UI thread

dltk.ui-SelectionDispatchAction-patch.diff (text/plain), 1.67 KB, created by Natalia Bartol

on 2012-01-18 07:34:48 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Natalia Bartol

Created: 2012-01-18 07:34:48 EST

Size: 1.67 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dltk.ui
>Index: src/org/eclipse/dltk/ui/actions/SelectionDispatchAction.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.ui/src/org/eclipse/dltk/ui/actions/SelectionDispatchAction.java,v
>retrieving revision 1.3
>diff -u -r1.3 SelectionDispatchAction.java
>--- src/org/eclipse/dltk/ui/actions/SelectionDispatchAction.java	15 May 2007 11:02:33 -0000	1.3
>+++ src/org/eclipse/dltk/ui/actions/SelectionDispatchAction.java	18 Jan 2012 12:33:29 -0000
>@@ -10,6 +10,10 @@
> package org.eclipse.dltk.ui.actions;
> 
> import org.eclipse.core.runtime.Assert;
>+import org.eclipse.core.runtime.IProgressMonitor;
>+import org.eclipse.core.runtime.IStatus;
>+import org.eclipse.core.runtime.Status;
>+import org.eclipse.core.runtime.jobs.Job;
> import org.eclipse.dltk.internal.ui.editor.ModelTextSelection;
> import org.eclipse.jface.action.Action;
> import org.eclipse.jface.text.ITextSelection;
>@@ -238,8 +242,19 @@
> 	/* (non-Javadoc)
> 	 * Method declared on ISelectionChangedListener.
> 	 */
>-	public void selectionChanged(SelectionChangedEvent event) {
>-		dispatchSelectionChanged(event.getSelection());
>+	public void selectionChanged(final SelectionChangedEvent event) {
>+		Job job = new Job("Dispatching selction changed event") {
>+
>+			@Override
>+			protected IStatus run(IProgressMonitor monitor) {
>+				dispatchSelectionChanged(event.getSelection());
>+				return Status.OK_STATUS;
>+			}
>+		};
>+		job.setSystem(true);
>+		job.setPriority(Job.DECORATE);
>+		job.schedule();
>+		
> 	}
> 
> 	private void dispatchSelectionChanged(ISelection selection) {

Actions: View | Diff

Attachments on bug 368950: 209673