Attachment 209386 Details for Bug 368304 – patch to only append newline if there's previous text

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch to only append newline if there's previous text

patch.txt (text/plain), 1.69 KB, created by David McKnight

on 2012-01-12 10:27:07 EST

(hide)

Description:

Filename:

MIME Type:

Creator: David McKnight

Created: 2012-01-12 10:27:07 EST

Size: 1.69 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/ui/actions/SystemCopyToClipboardAction.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/actions/SystemCopyToClipboardAction.java,v
>retrieving revision 1.18
>diff -u -r1.18 SystemCopyToClipboardAction.java
>--- UI/org/eclipse/rse/ui/actions/SystemCopyToClipboardAction.java	16 Mar 2011 16:46:05 -0000	1.18
>+++ UI/org/eclipse/rse/ui/actions/SystemCopyToClipboardAction.java	12 Jan 2012 15:25:31 -0000
>@@ -18,6 +18,7 @@
>  * David McKnight   (IBM)        - [223103] [cleanup] fix broken externalized strings
>  * David McKnight   (IBM)        - [248339] [dnd][encodings] Cannot drag&drop / copy&paste files or folders with turkish or arabic names
>  * David McKnight   (IBM)        - [330398] RSE leaks SWT resources
>+ * David McKnight   (IBM)        - [368304] Copy paste from Remote System Explorer view has CR/LF
>  *******************************************************************************/
> 
> package org.eclipse.rse.ui.actions;
>@@ -178,9 +179,13 @@
> 				if (adapter != null)
> 				{					
> 					String text = adapter.getAlternateText(dragObject);
>+					if (textStream.length() > 0){
>+						// append new line only if we've already got previous lines
>+						textStream.append(getTextTransferAppend(dragObject, adapter));
>+					}
>+					
> 					textStream.append(getTextTransferPrepend(dragObject, adapter));
>-					textStream.append(text);	
>-					textStream.append(getTextTransferAppend(dragObject, adapter));
>+					textStream.append(text);						
> 					
> 					if (adapter.canDrag(dragObject))
> 					{

Actions: View | Diff

Attachments on bug 368304: 209386