Attachment 209211 Details for Bug 368152 – Proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix

bug368152.patch (text/plain), 1.58 KB, created by Jay Arthanareeswaran

on 2012-01-09 09:52:21 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Jay Arthanareeswaran

Created: 2012-01-09 09:52:21 EST

Size: 1.58 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
>index d615698..192d097 100644
>--- a/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
>+++ b/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ExternalFoldersManager.java
>@@ -122,7 +122,7 @@
> 		} while (result.exists());
> 		if (scheduleForCreation) {
> 			if (this.pendingFolders == null)
>-				this.pendingFolders = new HashSet();
>+				this.pendingFolders = Collections.synchronizedSet(new HashSet());
> 			this.pendingFolders.add(externalFolderPath);
> 		}
> 		knownFolders.put(externalFolderPath, result);
>@@ -166,13 +166,15 @@
> 		catch(CoreException e) {
> 			throw new JavaModelException(e);
> 		}
>-		Iterator iterator = this.pendingFolders.iterator();
>-		while (iterator.hasNext()) {
>-			Object folderPath = iterator.next();
>-			try {
>-				createLinkFolder((IPath) folderPath, false, externalFoldersProject, monitor);
>-			} catch (CoreException e) {
>-				Util.log(e, "Error while creating a link for external folder :" + folderPath); //$NON-NLS-1$
>+		synchronized (this.pendingFolders) {
>+			Iterator iterator = this.pendingFolders.iterator();
>+			while (iterator.hasNext()) {
>+				Object folderPath = iterator.next();
>+				try {
>+					createLinkFolder((IPath) folderPath, false, externalFoldersProject, monitor);
>+				} catch (CoreException e) {
>+					Util.log(e, "Error while creating a link for external folder :" + folderPath); //$NON-NLS-1$
>+				}
> 			}
> 		}
> 		this.pendingFolders.clear();

Actions: View | Diff

Attachments on bug 368152: 209211 | 209869 | 209871 | 210971