Attachment 207559 Details for Bug 364802 – Proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix

clipboard.txt (text/plain), 2.77 KB, created by Rüdiger Herrmann

on 2011-11-25 15:49:05 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Rüdiger Herrmann

Created: 2011-11-25 15:49:05 EST

Size: 2.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/swt/custom/TableEditor.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/custom/TableEditor.java,v
>retrieving revision 1.7
>diff -u -r1.7 TableEditor.java
>--- src/org/eclipse/swt/custom/TableEditor.java	13 Sep 2011 13:20:14 -0000	1.7
>+++ src/org/eclipse/swt/custom/TableEditor.java	25 Nov 2011 20:45:37 -0000
>@@ -10,6 +10,10 @@
>  *******************************************************************************/
> package org.eclipse.swt.custom;
> 
>+import org.eclipse.rwt.RWT;
>+import org.eclipse.rwt.lifecycle.PhaseEvent;
>+import org.eclipse.rwt.lifecycle.PhaseId;
>+import org.eclipse.rwt.lifecycle.PhaseListener;
> import org.eclipse.swt.*;
> import org.eclipse.swt.events.*;
> import org.eclipse.swt.graphics.*;
>@@ -76,7 +80,7 @@
> 	TableItem item;
> 	int column = -1;
> 	ControlListener columnListener;
>-	Runnable timer;
>+//	Runnable timer;
> 	static final int TIMEOUT = 1500;
> /**
> * Creates a TableEditor for the specified Table.
>@@ -96,11 +100,11 @@
> 			layout ();
> 		}
> 	};
>-	timer = new SerializableRunnable () {
>-		public void run() {
>-			layout ();
>-		}
>-	};
>+//	timer = new Runnable () {
>+//		public void run() {
>+//			layout ();
>+//		}
>+//	};
> 
> 	// To be consistent with older versions of SWT, grabVertical defaults to true
> 	grabVertical = true;
>@@ -164,7 +168,7 @@
> 	table = null;
> 	item = null;
> 	column = -1;
>-	timer = null;
>+//	timer = null;
> 	super.dispose();
> }
> /**
>@@ -185,17 +189,33 @@
> }
> void resize () {
> 	layout();
>-//	/*
>-//	 * On some platforms, the table scrolls when an item that
>-//	 * is partially visible at the bottom of the table is
>-//	 * selected.  Ensure that the correct row is edited by
>-//	 * laying out one more time in a timerExec().
>-//	 */
>+	/*
>+	 * On some platforms, the table scrolls when an item that
>+	 * is partially visible at the bottom of the table is
>+	 * selected.  Ensure that the correct row is edited by
>+	 * laying out one more time in a timerExec().
>+	 */
> //	if (table != null) {
> //		Display display = table.getDisplay();
> //		display.timerExec(-1, timer);
> //		display.timerExec(TIMEOUT, timer);
> //	}
>+	// [rh] Adaption of the above code for RWT (see bug 364802)
>+	RWT.getLifeCycle().addPhaseListener( new PhaseListener() {
>+    public void beforePhase( PhaseEvent event ) {
>+    }
>+    
>+    public void afterPhase( PhaseEvent event ) {
>+      RWT.getLifeCycle().removePhaseListener( this );
>+      if( table != null && table.getDisplay() == Display.getCurrent() ) {
>+        layout();
>+      }
>+    }
>+
>+    public PhaseId getPhaseId() {
>+      return PhaseId.PROCESS_ACTION;
>+    }
>+  } );
> }
> /**
> * Sets the zero based index of the column of the cell being tracked by this editor.

Actions: View | Diff

Attachments on bug 364802: 207559