Attachment 206842 Details for Bug 363582 – Fix pre-existing warnings in SearchField - Apply after real patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix pre-existing warnings in SearchField - Apply after real patch

bug365382-warnings.txt (text/plain), 3.25 KB, created by Dean Roberts

on 2011-11-11 08:45:27 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Roberts

Created: 2011-11-11 08:45:27 EST

Size: 3.25 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java
>index bcbc736..1363c89 100644
>--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java
>+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java
>@@ -18,13 +18,11 @@
> import javax.annotation.PreDestroy;
> import org.eclipse.core.commands.AbstractHandler;
> import org.eclipse.core.commands.ExecutionEvent;
>-import org.eclipse.core.commands.ExecutionException;
> import org.eclipse.core.expressions.EvaluationResult;
> import org.eclipse.core.expressions.Expression;
> import org.eclipse.core.expressions.ExpressionInfo;
> import org.eclipse.core.expressions.IEvaluationContext;
> import org.eclipse.core.runtime.Assert;
>-import org.eclipse.core.runtime.CoreException;
> import org.eclipse.e4.core.contexts.IEclipseContext;
> import org.eclipse.e4.ui.model.application.MApplication;
> import org.eclipse.e4.ui.model.application.ui.basic.MWindow;
>@@ -190,7 +188,7 @@
> 			}
> 
> 			@Override
>-			public EvaluationResult evaluate(IEvaluationContext context) throws CoreException {
>+			public EvaluationResult evaluate(IEvaluationContext context) {
> 				return EvaluationResult.valueOf(SearchField.class.getName().equals(
> 						context.getVariable(ISources.ACTIVE_FOCUS_CONTROL_ID_NAME)));
> 			}
>@@ -199,25 +197,25 @@
> 		IHandlerService whService = windowContext.get(IHandlerService.class);
> 		whService.activateHandler(IWorkbenchCommandConstants.EDIT_SELECT_ALL,
> 				new AbstractHandler() {
>-					public Object execute(ExecutionEvent event) throws ExecutionException {
>+					public Object execute(ExecutionEvent event) {
> 						text.selectAll();
> 						return null;
> 					}
> 				}, focusExpr);
> 		whService.activateHandler(IWorkbenchCommandConstants.EDIT_CUT, new AbstractHandler() {
>-			public Object execute(ExecutionEvent event) throws ExecutionException {
>+			public Object execute(ExecutionEvent event) {
> 				text.cut();
> 				return null;
> 			}
> 		}, focusExpr);
> 		whService.activateHandler(IWorkbenchCommandConstants.EDIT_COPY, new AbstractHandler() {
>-			public Object execute(ExecutionEvent event) throws ExecutionException {
>+			public Object execute(ExecutionEvent event) {
> 				text.copy();
> 				return null;
> 			}
> 		}, focusExpr);
> 		whService.activateHandler(IWorkbenchCommandConstants.EDIT_PASTE, new AbstractHandler() {
>-			public Object execute(ExecutionEvent event) throws ExecutionException {
>+			public Object execute(ExecutionEvent event) {
> 				text.paste();
> 				return null;
> 			}
>@@ -226,8 +224,6 @@
> 
> 	/**
> 	 * This method was copy/pasted from JFace.
>-	 * 
>-	 * @see org.eclipse.jface.window.Window#getClosestMonitor(Display, Point)
> 	 */
> 	private static Monitor getClosestMonitor(Display toSearch, Point toFind) {
> 		int closest = Integer.MAX_VALUE;
>@@ -256,9 +252,6 @@
> 
> 	/**
> 	 * This method was copy/pasted from JFace.
>-	 * 
>-	 * @see org.eclipse.jface.window.Window#getConstrainedShellBounds(Display,
>-	 *      Rectangle)
> 	 */
> 	private Rectangle getConstrainedShellBounds(Display display, Rectangle preferredSize) {
> 		Rectangle result = new Rectangle(preferredSize.x, preferredSize.y, preferredSize.width,

Actions: View | Diff

Attachments on bug 363582: 206841 | 206842