Attachment 2068 Details for Bug 2417 – Prevent link activation, and cursor change on drag events

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Prevent link activation, and cursor change on drag events

2417b_patch.txt (text/plain), 1.63 KB, created by Andrew Irvine

on 2002-09-26 13:37:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Irvine

Created: 2002-09-26 13:37:10 EDT

Size: 1.63 KB

patch

obsolete

>Index: WelcomeEditor.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WelcomeEditor.java,v
>retrieving revision 1.2
>diff -u -r1.2 WelcomeEditor.java
>--- WelcomeEditor.java	25 Sep 2002 18:58:13 -0000	1.2
>+++ WelcomeEditor.java	26 Sep 2002 17:36:25 -0000
>@@ -61,6 +61,8 @@
> 	private ScrolledComposite scrolledComposite;
> 	
> 	private IPropertyChangeListener colorListener;
>+	private boolean mouseDown = false;
>+	private boolean dragEvent = false;
> 		
> 	
> 	/**
>@@ -201,7 +203,19 @@
>  */
> private void addListeners(StyledText styledText) {
> 	styledText.addMouseListener(new MouseAdapter() {
>+		public void mouseDown(MouseEvent e) {
>+			if (e.button != 1) {
>+				return;
>+			}
>+			mouseDown = true;
>+		}
> 		public void mouseUp(MouseEvent e) {
>+			mouseDown = false;
>+			// Do not activate links on drag events
>+			if (dragEvent) {
>+				dragEvent = false;
>+				return;
>+			}
> 			StyledText text = (StyledText)e.widget;
> 			WelcomeItem item = (WelcomeItem)e.widget.getData();
> 			int offset = text.getCaretOffset();
>@@ -214,6 +228,15 @@
> 	});
> 	styledText.addMouseMoveListener(new MouseMoveListener() {
> 		public void mouseMove(MouseEvent e) {
>+			// Do not change cursor on drag events
>+			if (mouseDown) {
>+				if (!dragEvent) {
>+					StyledText text = (StyledText)e.widget;
>+					text.setCursor(null);
>+				}
>+				dragEvent = true;
>+				return;
>+			}
> 			StyledText text = (StyledText)e.widget;
> 			WelcomeItem item = (WelcomeItem)e.widget.getData();
> 			int offset = getOffsetAtLocation(text, e.x, e.y);

Actions: View | Diff

Attachments on bug 2417: 2065 | 2068 | 2070