Attachment 206656 Details for Bug 352572 – revised patch for 1.4 branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] revised patch for 1.4 branch

bug352572b_sr142.patch (text/plain), 1.27 KB, created by Tim Buschtoens

on 2011-11-09 04:50:55 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2011-11-09 04:50:55 EST

Size: 1.27 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/ErrorHandler.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/Attic/ErrorHandler.js,v
>retrieving revision 1.2
>diff -u -r1.2 ErrorHandler.js
>--- js/org/eclipse/rwt/ErrorHandler.js	10 May 2011 14:40:16 -0000	1.2
>+++ js/org/eclipse/rwt/ErrorHandler.js	9 Nov 2011 09:46:45 -0000
>@@ -59,9 +59,19 @@
>     },
> 
>     processJavaScriptError : function( error ) {
>-      var content = "<p>Javascript error occurred:</p><pre>"  + error + "</pre>";
>-      org.eclipse.rwt.ErrorHandler.showError( content );
>-      throw error;
>+      if( qx.core.Variant.isSet( "qx.debug", "on" ) ) {
>+        var content = "<p>Javascript error occurred:</p><pre>"  + error + "</pre>";
>+        org.eclipse.rwt.ErrorHandler.showError( content );
>+        throw error;
>+      } else {
>+        if( typeof console === "object" ) {
>+          if( typeof console.error === "function" ) {
>+            console.error( error );
>+          } else if( typeof console.log === "function" ) {
>+            console.log( error );
>+          }
>+        }
>+      }
>     },
> 
>     _createOverlay : function() {

Flags:

tbuschto: review?

Actions: View | Diff

Attachments on bug 352572: 206595 | 206656