Attachment 206595 Details for Bug 352572 – patch for 1.4 branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for 1.4 branch

bug352572_sr142.patch (text/plain), 1.30 KB, created by Tim Buschtoens

on 2011-11-08 09:30:41 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2011-11-08 09:30:41 EST

Size: 1.30 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/ErrorHandler.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/Attic/ErrorHandler.js,v
>retrieving revision 1.2
>diff -u -r1.2 ErrorHandler.js
>--- js/org/eclipse/rwt/ErrorHandler.js	10 May 2011 14:40:16 -0000	1.2
>+++ js/org/eclipse/rwt/ErrorHandler.js	8 Nov 2011 13:02:31 -0000
>@@ -59,9 +59,23 @@
>     },
> 
>     processJavaScriptError : function( error ) {
>-      var content = "<p>Javascript error occurred:</p><pre>"  + error + "</pre>";
>-      org.eclipse.rwt.ErrorHandler.showError( content );
>-      throw error;
>+      if( qx.core.Variant.isSet( "qx.debug", "on" ) ) {
>+        var content = "<p>Javascript error occurred:</p><pre>"  + error + "</pre>";
>+        org.eclipse.rwt.ErrorHandler.showError( content );
>+        throw error;
>+      } else {
>+        if( console ) {
>+          try {
>+            if( console.error ) {
>+              console.error( error );
>+            } else if( console.log ) {
>+              console.log( error );
>+            }
>+          } catch( ex ) {
>+            // ignore
>+          }
>+        }
>+      }
>     },
> 
>     _createOverlay : function() {

Actions: View | Diff

Attachments on bug 352572: 206595 | 206656