Attachment 205353 Details for Bug 361029 – Fix patch for review

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix patch for review

bug361029_patch.txt (text/plain), 1.94 KB, created by libing wang

on 2011-10-17 12:56:53 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: libing wang

Created: 2011-10-17 12:56:53 EDT

Size: 1.94 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.git/web/orion/git/git-status-table.js b/bundles/org.eclipse.orion.client.git/web/orion/git/git-status-table.js
>index 4ccd37f..6df71fa 100644
>--- a/bundles/org.eclipse.orion.client.git/web/orion/git/git-status-table.js
>+++ b/bundles/org.eclipse.orion.client.git/web/orion/git/git-status-table.js
>@@ -801,20 +801,26 @@ orion.GitStatusController = (function() {
> 		_initTitleBar:function(withBranchName){
> 			var title = "Git Status";
> 			var location = "";
>+			var branchName = this._curBranch ? this._curBranch.Name : "detached";
> 			if(withBranchName) {
>-				var name =  this._curBranch ? this._curBranch.Name : "detached";
>-				location = this._curClone.Name + " on " + name;
>+				location = this._curClone.Name + " on " + branchName;
> 			}
>+			//render browser title
> 			document.title = location;
>-			// not good that these dom id's are known way down here
>+			
>+			//render page title
> 			dojo.place(document.createTextNode(title), "pageTitle", "only");
>-			dojo.place(document.createTextNode(location), "location", "only");
> 			if(withBranchName) {
>-				this._logTableRenderer.modifyHeader(this._curBranch ? this._curBranch.Name : "detached");
>-				if(this._curBranch && this._curRemote)
>-					this._remoteTableRenderer.modifyHeader((this._curRemote ? this._curRemote.Name : "") + "/" + this._curBranch.Name);
>+				//render git log title on local branch 
>+				this._logTableRenderer.modifyHeader(branchName);
>+				if(this._curBranch && this._curRemote){
>+					branchName = (this._curBranch.RemoteLocation.length > 0 ? this._curBranch.RemoteLocation[0].Name : "") + "/" + this._curBranch.Name;
>+					//render git log title on remote branch
>+					this._remoteTableRenderer.modifyHeader(branchName);
>+				}
>+				//render page tilte details (clone name + remote name + local branch name)
>+				dojo.place(document.createTextNode(this._curClone.Name + " on " + branchName), "location", "only");
> 			}
>-				
> 		},
> 		
> 		_getCloneInfo:function(){

Actions: View | Diff

Attachments on bug 361029: 205234 | 205353