Attachment 205308 Details for Bug 361098 – Patch that solves the problem

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch that solves the problem

Bug-361098.patch (text/plain), 2.62 KB, created by Ivan Furnadjiev

on 2011-10-17 07:22:32 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-10-17 07:22:32 EDT

Size: 2.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: js/org/eclipse/rwt/widgets/Tree.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/js/org/eclipse/rwt/widgets/Tree.js,v
>retrieving revision 1.4
>diff -u -r1.4 Tree.js
>--- js/org/eclipse/rwt/widgets/Tree.js	23 Aug 2011 10:06:56 -0000	1.4
>+++ js/org/eclipse/rwt/widgets/Tree.js	17 Oct 2011 11:21:46 -0000
>@@ -904,7 +904,7 @@
>     // focus & selection
> 
>     _singleSelectItem : function( event, item ) {
>-      if( event instanceof qx.event.type.KeyEvent && event.isCtrlPressed() ) {
>+      if( event.isCtrlPressed() && this.isItemSelected( item ) ) {
>         // NOTE: Apparently in SWT this is only supported by Table, not Tree.
>         //       No reason not to support it in RAP though.
>         this._ctrlSelectItem( item );
>#P org.eclipse.rap.rwt.jstest
>Index: js/org/eclipse/rwt/test/tests/TreeTest.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.jstest/js/org/eclipse/rwt/test/tests/TreeTest.js,v
>retrieving revision 1.41
>diff -u -r1.41 TreeTest.js
>--- js/org/eclipse/rwt/test/tests/TreeTest.js	23 Aug 2011 10:06:32 -0000	1.41
>+++ js/org/eclipse/rwt/test/tests/TreeTest.js	17 Oct 2011 11:21:47 -0000
>@@ -1006,7 +1006,7 @@
>       assertFalse( tree.isItemSelected( item1 ) );
>       assertFalse( tree.isItemSelected( item2 ) );
>       tree.destroy();
>-    },    
>+    },
> 
>     testShiftMultiSelection : function() {
>       var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>@@ -2564,7 +2564,23 @@
>       assertFalse( tree.isItemSelected( item2 ) );
>       tree.destroy();
>     },
>-    
>+
>+    testKeyboardNavigationCtrlUpDown : function() {
>+      var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>+      var tree = this._createDefaultTree();
>+      tree.setItemCount( 3 );
>+      var item0 = new org.eclipse.rwt.widgets.TreeItem( tree.getRootItem(), 0 );
>+      var item1 = new org.eclipse.rwt.widgets.TreeItem( tree.getRootItem(), 1 );
>+      var item2 = new org.eclipse.rwt.widgets.TreeItem( tree.getRootItem(), 2 );
>+      testUtil.flush();
>+      testUtil.click( tree._rowContainer._children[ 0 ] );
>+      testUtil.pressOnce( tree, "Down", qx.event.type.DomEvent.CTRL_MASK );
>+      assertFalse( tree.isItemSelected( item0 ) );
>+      assertTrue( tree.isItemSelected( item1 ) );
>+      assertFalse( tree.isItemSelected( item2 ) );
>+      tree.destroy();
>+    },
>+
>     testKeyboardNavigationRight : function() {
>       var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>       var tree = this._createDefaultTree();

Actions: View | Diff

Attachments on bug 361098: 205308