Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 205300 Details for
Bug 361052
Focused cell is not highlighted if navigating with CTRL + Arrow Up/Down
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
Proposed patch
Bug-361052.patch (text/plain), 3.23 KB, created by
Ivan Furnadjiev
on 2011-10-17 04:15:31 EDT
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Ivan Furnadjiev
Created:
2011-10-17 04:15:31 EDT
Size:
3.23 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.rap.jface >Index: src/org/eclipse/jface/viewers/TableViewerFocusCellManager.java >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.ui/org.eclipse.rap.jface/src/org/eclipse/jface/viewers/TableViewerFocusCellManager.java,v >retrieving revision 1.7 >diff -u -r1.7 TableViewerFocusCellManager.java >--- src/org/eclipse/jface/viewers/TableViewerFocusCellManager.java 28 Nov 2010 18:27:11 -0000 1.7 >+++ src/org/eclipse/jface/viewers/TableViewerFocusCellManager.java 17 Oct 2011 08:14:06 -0000 >@@ -88,21 +88,23 @@ > private boolean columnInVisibleArea(Rectangle clientArea, ViewerRow row, int colIndex) { > return row.getBounds(colIndex).x >= clientArea.x; > } >- >- public ViewerCell getFocusCell() { >- ViewerCell cell = super.getFocusCell(); >- Table t = (Table) getViewer().getControl(); >- >- // It is possible that the selection has changed under the hood >- if (cell != null) { >- if (t.getSelection().length == 1 >- && t.getSelection()[0] != cell.getItem()) { >- setFocusCell(getViewer().getViewerRowFromItem( >- t.getSelection()[0]).getCell(cell.getColumnIndex())); >- } >- } >- >- return super.getFocusCell(); >- } > >+// RAP [if] 361052: Focused cell is not highlighted if navigating with CTRL + Arrow Up/Down >+// https://bugs.eclipse.org/bugs/show_bug.cgi?id=361052 >+// public ViewerCell getFocusCell() { >+// ViewerCell cell = super.getFocusCell(); >+// Table t = (Table) getViewer().getControl(); >+// >+// // It is possible that the selection has changed under the hood >+// if (cell != null) { >+// if (t.getSelection().length == 1 >+// && t.getSelection()[0] != cell.getItem()) { >+// setFocusCell(getViewer().getViewerRowFromItem( >+// t.getSelection()[0]).getCell(cell.getColumnIndex())); >+// } >+// } >+// >+// return super.getFocusCell(); >+// } >+// RAPEND > } >#P org.eclipse.rap.rwt >Index: js/org/eclipse/rwt/AsyncKeyEventUtil.js >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/js/org/eclipse/rwt/AsyncKeyEventUtil.js,v >retrieving revision 1.1 >diff -u -r1.1 AsyncKeyEventUtil.js >--- js/org/eclipse/rwt/AsyncKeyEventUtil.js 7 Jul 2011 11:22:22 -0000 1.1 >+++ js/org/eclipse/rwt/AsyncKeyEventUtil.js 17 Oct 2011 08:14:07 -0000 >@@ -144,13 +144,15 @@ > var result = false; > if( qx.core.Variant.isSet( "qx.client", "gecko" ) ) { > var tagName = domEvent.target.tagName.toLowerCase(); >- // Check for CTRL key fixes bug 282837 >- if( domEvent.ctrlKey ) { >- result = true; >- } else if( tagName == "input" || tagName == "textarea" ) { >- for( var i = 0; !result && i < this._untrustedKeyCodes.length; i++ ) { >- if( this._untrustedKeyCodes[ i ] === keyCode ) { >- result = true; >+ if( tagName == "input" || tagName == "textarea" ) { >+ // Check for CTRL key fixes bug 282837 >+ if( domEvent.ctrlKey ) { >+ result = true; >+ } else { >+ for( var i = 0; !result && i < this._untrustedKeyCodes.length; i++ ) { >+ if( this._untrustedKeyCodes[ i ] === keyCode ) { >+ result = true; >+ } > } > } > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 361052
: 205300