Attachment 204863 Details for Bug 360412 – Proposed patch for v1.4_Maintenance branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch for v1.4_Maintenance branch

Bug-360412-v14.patch (text/plain), 2.18 KB, created by Ivan Furnadjiev

on 2011-10-10 05:53:22 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-10-10 05:53:22 EDT

Size: 2.18 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Attic/Combo.js,v
>retrieving revision 1.56.2.1
>diff -u -r1.56.2.1 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	18 May 2011 08:27:05 -0000	1.56.2.1
>+++ js/org/eclipse/swt/widgets/Combo.js	10 Oct 2011 09:49:46 -0000
>@@ -605,6 +605,7 @@
>           } else if( this._list.getItemsCount() ) {
>             this._setSelected( this._list.getItems()[0] );
>           }
>+          evt.stopPropagation();
>           break;
>       }
>       if(    this._field.isCreated()
>#P org.eclipse.rap.rwt.q07.jstest
>Index: js/org/eclipse/rwt/test/tests/ComboTest.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.q07.jstest/js/org/eclipse/rwt/test/tests/Attic/ComboTest.js,v
>retrieving revision 1.11.2.1.2.1
>diff -u -r1.11.2.1.2.1 ComboTest.js
>--- js/org/eclipse/rwt/test/tests/ComboTest.js	25 Aug 2011 12:50:38 -0000	1.11.2.1.2.1
>+++ js/org/eclipse/rwt/test/tests/ComboTest.js	10 Oct 2011 09:49:48 -0000
>@@ -230,6 +230,29 @@
>       combo.destroy();
>     },
> 
>+    testStopArrowKeysPropagation : function() {
>+      var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>+      var composite = new org.eclipse.swt.widgets.Composite();
>+      composite.setSpace( 0, 100, 0, 100 );
>+      var combo = new org.eclipse.swt.widgets.Combo();
>+      combo.setSpace( 239, 81, 6, 23 );
>+      combo.setParent( composite );
>+      composite.addToDocument();
>+      testUtil.flush();
>+      combo.focus();
>+      var counter = 0;
>+      composite.addEventListener( "keypress", function( event ) {
>+        counter++
>+      } );
>+      testUtil.keyDown( combo._getTargetNode(), "PageUp" );
>+      testUtil.keyDown( combo._getTargetNode(), "Up" );
>+      testUtil.keyDown( combo._getTargetNode(), "Down" );
>+      testUtil.keyDown( combo._getTargetNode(), "PageDown" );
>+      assertEquals( 0, counter );
>+      combo.destroy();
>+      composite.destroy(); 
>+    },
>+
>     //////////
>     // Helpers
>

Flags:

rsternberg: review+

Actions: View | Diff

Attachments on bug 360412: 204863