Attachment 204786 Details for Bug 359807 – Proposed patch for v14_Maintenance branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch for v14_Maintenance branch

Bug-359807-v1.4.patch (text/plain), 1.80 KB, created by Ivan Furnadjiev

on 2011-10-08 01:53:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-10-08 01:53:57 EDT

Size: 1.80 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/swt/widgets/Control.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/widgets/Control.java,v
>retrieving revision 1.83
>diff -u -r1.83 Control.java
>--- src/org/eclipse/swt/widgets/Control.java	5 May 2011 07:43:11 -0000	1.83
>+++ src/org/eclipse/swt/widgets/Control.java	8 Oct 2011 05:52:29 -0000
>@@ -2317,7 +2317,7 @@
>     if( updateMode ) {
>       updateMode();
>     }
>-    packed = false;
>+    clearPacked( oldSize );
>     notifyMove( oldLocation );
>     notifyResize( oldSize );
>   }
>@@ -2325,6 +2325,12 @@
>   void updateMode() {
>     // subclasses may override
>   }
>+  
>+  private void clearPacked( Point oldSize ) {
>+    if( !oldSize.equals( getSize() ) ) {
>+      packed = false;
>+    }
>+  }
> 
>   void notifyResize( final Point oldSize ) {
>     if( !oldSize.equals( getSize() ) ) {
>#P org.eclipse.rap.rwt.test
>Index: src/org/eclipse/swt/widgets/Control_Test.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.test/src/org/eclipse/swt/widgets/Control_Test.java,v
>retrieving revision 1.39
>diff -u -r1.39 Control_Test.java
>--- src/org/eclipse/swt/widgets/Control_Test.java	16 May 2011 15:01:30 -0000	1.39
>+++ src/org/eclipse/swt/widgets/Control_Test.java	8 Oct 2011 05:52:29 -0000
>@@ -996,4 +996,13 @@
>       // Expected Exception
>     }
>   }
>+  
>+  public void testNotClearPackedOnSetLocation() {
>+    shell.pack();
>+
>+    shell.setLocation( 1, 2 );
>+
>+    IControlAdapter controlAdapter = ( IControlAdapter )shell.getAdapter( IControlAdapter.class );
>+    assertTrue( controlAdapter.isPacked() );
>+  }
> }

Flags:

ruediger.herrmann: review+

Actions: View | Diff

Attachments on bug 359807: 204498 | 204786